Skip to content

feat(sca): onboard sca service - #11373

Open
JYisus wants to merge 19 commits into
stackitcloud:mainfrom
JYisus:oas-bot-34598867041/sca
Open

JYisus wants to merge 19 commits into
stackitcloud:mainfrom
JYisus:oas-bot-34598867041/sca

Conversation

@JYisus

@JYisus JYisus commented Sep 14, 2026

Copy link
Copy Markdown

Description

  • Auto-generated SCA code.
  • Include required meta files (RELEASE.md, VERSION, CHANGELOG.md)
  • Implement waiters.
  • Create examples

JIRA issue: https://jira.schwarz/browse/SCA-231

Checklist

  • Issue was linked above
  • No generated code was adjusted manually (check comments in file header)
  • Changelogs
    • Changelog in the root directory was adjusted (see here)
    • Changelog(s) of the service(s) were adjusted (see e.g. here)
  • VERSION file(s) of the service(s) were adjusted
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@JYisus
JYisus requested a review from a team as a code owner September 14, 2026 11:54
Comment thread go.work
Comment thread examples/sca/sca.go Outdated
@rubenhoenle

Copy link
Copy Markdown
Member

Just some quick feedback after a first glance, a detailed review will follow from the collegues responsible for your domain :)

@JYisus
JYisus requested a review from rubenhoenle September 14, 2026 12:36
Comment thread examples/sca/sca.go
Comment thread services/sca/LICENSE.md Outdated
Comment thread services/sca/v1alphaapi/wait/wait_test.go
Comment thread services/sca/v1alphaapi/wait/wait_test.go Outdated
Comment thread services/sca/v1alphaapi/wait/wait_test.go Outdated
Comment thread examples/sca/sca.go Outdated
Comment thread examples/sca/sca.go Outdated
Comment thread examples/sca/sca.go Outdated
Comment thread examples/sca/sca.go
Comment thread examples/sca/sca.go Outdated
Comment thread examples/sca/sca.go Outdated
Comment thread services/sca/v1alphaapi/wait/wait.go
Comment thread services/sca/v1alphaapi/wait/wait.go
Comment thread services/sca/v1alphaapi/wait/wait.go
Comment thread examples/sca/sca.go
Comment thread examples/sca/sca.go Outdated
Comment thread services/sca/v1alphaapi/wait/wait_test.go
Comment thread examples/sca/sca.go
Comment thread examples/sca/sca.go Outdated
FetchInstance: a.GetApplication(ctx, projectID, environmentID, applicationID).Execute,
GetState: getApplicationState,
ActiveState: []sca.CurrentStatus{sca.CURRENTSTATUS_CURRENT_STATUS_RUNNING, sca.CURRENTSTATUS_CURRENT_STATUS_IDLE},
// ErrorState: []sca.CurrentStatus{sca.CURRENTSTATUS_CURRENT_STATUS_FAILED},

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the ErrorState commented out?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TLDR: during startup, the API reports an error state but it is able to recover from it.

An Application is essentially a Kubernetes deployment, so we use deployment conditions to check for availability. In some cases during the startup phase, we aren't handling these conditions correctly, which results in a transient failed status. We are working on a fix and plan to open a new PR that includes additional features. As we are still in beta, we are continuing to identify and address these edge cases.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand, since you are even on alpha I would say it's fine for now. But please fix it until beta because otherwise it becomes difficult for the integration in the Tools (Terraform, CLI, Pulumi) since they are using this waiter. When the create or update fails, the waiter doesn't detect it at the moment because it doesn't know any error states. The only option that the waiter stops during a failed create / update is the timeout, which is at the moment 45 minutes. This means if in the first 5 minutes it's already clear that the application failed, the tools still continue to wait 40 minutes until they hit the timeout.

Can you add a comment to this line that there is this issue at the moment and that it will be fixed until your service is in beta?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@JYisus
JYisus requested a review from marceljk September 17, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants