Skip to content

fix: Add missing owns/watches and test early-exit reconcile - #882

Merged
adwk67 merged 3 commits into
mainfrom
fix/missing-owns-and-early-exit
Aug 25, 2026
Merged

fix: Add missing owns/watches and test early-exit reconcile#882
adwk67 merged 3 commits into
mainfrom
fix/missing-owns-and-early-exit

Conversation

@adwk67

@adwk67 adwk67 commented Aug 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Part of stackabletech/issues#878

This PR ensures that the operator now watches all resources that it creates and early-exits the reconcile action when the cluster is marked for deletion. This is tested at unit-test level, as well as by adding a step to one of the kuttl tests to delete all relevant objects and assert that they are re-created.

--- PASS: kuttl (100.17s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/cluster-operation_opa-latest-1.16.2_openshift-false (100.15s)
PASS

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added in parent issue

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@adwk67 adwk67 mentioned this pull request Aug 25, 2026
Closed
13 tasks
@adwk67 adwk67 self-assigned this Aug 25, 2026
@adwk67
adwk67 requested a review from maltesander August 25, 2026 08:57
@adwk67
adwk67 marked this pull request as ready for review August 25, 2026 08:57
@adwk67
adwk67 enabled auto-merge August 25, 2026 15:44
maltesander
maltesander approved these changes Aug 25, 2026
View reviewed changes

@maltesander maltesander left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adwk67
adwk67 added this pull request to the merge queue Aug 25, 2026
Merged via the queue into main with commit 97e579b Aug 25, 2026
13 checks passed
@adwk67
adwk67 deleted the fix/missing-owns-and-early-exit branch August 25, 2026 16:05
maltesander added a commit that referenced this pull request Aug 28, 2026
@maltesander @claude
Merge branch 'main' into spike/rif
52911c1 
main added `reconcile_exits_early_for_deleted_cluster` (#882), which builds a
`Ctx`, while this branch added the `resource_info_fetcher_image` field to it.
Neither side touches the other's lines, so the merge is clean textually but the
result did not compile, which is what the CI cargo-udeps job tripped over
before it got as far as looking for unused dependencies. Set the new field in
that test.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ECuWdW5czbvyp1WtEGz9r7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maltesander maltesander maltesander approved these changes

Assignees

@adwk67 adwk67

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adwk67 @maltesander