fix: Fix various broken links in docs (#779)

[xeniape]

Description

Please add a description here. This will become the commit message of the merge request later.

Definition of Done Checklist

• Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
• Please make sure all these things are done and tick the boxes

Author

• Changes are OpenShift compatible
• CRD changes approved
• CRD documentation for all fields, following the style guide.
• Helm chart can be installed and deployed operator works
• Integration tests passed (for non trivial changes)
• Changes need to be "offline" compatible
• Links to generated (nightly) docs added
• Release note snippet added

Reviewer

• Code contains useful comments
• Code contains useful logging statements
• (Integration-)Test cases added
• Documentation added or updated. Follows the style guide.
• Changelog updated
• Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

• Feature Tracker has been updated
• Proper release label has been added
• Links to generated (nightly) docs added
• Release note snippet added
• Add type/deprecation label & add to the deprecation schedule
• Add type/experimental label & add to the experimental features tracker

• fix: Fix broken link to AirflowCluster CRD docs

• broken link and external links

• broken link and external links

[lfrancke]

CI fails

[NickLarsenNZ]

CI fails

I took a look, and it seems like something is broken. An interpolation, or replacement.

Run curl --output /home/runner/.cargo/bin/ https://github.com/stackabletech/cargo-install-action/releases/download//-x86_64 --location --silent --show-error --fail --retry 5
curl: (22) The requested URL returned error: 404

I reran it, but same error. I'll see if I can figure it out.

[xeniape]

CI fails

I took a look, and it seems like something is broken. An interpolation, or replacement.

Run curl --output /home/runner/.cargo/bin/ https://github.com/stackabletech/cargo-install-action/releases/download//-x86_64 --location --silent --show-error --fail --retry 5
curl: (22) The requested URL returned error: 404

I reran it, but same error. I'll see if I can figure it out.

When I check out an older release branch it usually complains about an old rust version in the toolchain file.

I just assume that's because we don't update that in older branches and that's why it's also failing on PRs. Was never relevant to me for the doc changes, so I ignored it for now. But of course might also be something different.

[NickLarsenNZ]

But of course might also be something different.

This one is different.

Seems to be to do with inputs on this action:

https://github.com/stackabletech/cargo-install-action/blame/e3e2dcf8d0f0e5bdbc619bf6ee7560dd68152d3c/action.yml#L22-L23

[NickLarsenNZ]

My guess is that the inline interpolation is no longer allowed:

      run: curl --output ${{steps.cargo.outputs.dir}}/${{inputs.bin || inputs.crate}} https://github.com/stackabletech/cargo-install-action/releases/download/${{inputs.crate}}/${{inputs.bin || inputs.crate}}-${{steps.arch.outputs.arch}} --location --silent --show-error --fail --retry 5

It will instead need some env vars set, like:

      env:
        INPUT_CRATE: ${{inputs.crate}}
        INPUT_BIN: ${{inputs.bin || inputs.crate}}
      run: curl --output ${{steps.cargo.outputs.dir}}/ https://github.com/stackabletech/cargo-install-action/releases/download/$INPUT_CRATE/$INPUT_BIN-${{steps.arch.outputs.arch}} --location --silent --show-error --fail --retry 5

The rest seems to allow interpolations (ie: ${{steps.*}}).

[NickLarsenNZ]

Fixed in #859