refactor(render) :: drop the unread component name in handle_row - #1428
Merged
lovasoa merged 1 commit intoSep 6, 2026
Merged
Conversation
81reap
marked this pull request as ready for review
September 6, 2026 07:06
Collaborator
Author
|
CI failure is unrelated to this change, it comes from this commit on main 4c60e5d |
`handle_row` looked up the current component's name and then only checked whether a component was open at all. The name was never read.
lovasoa
force-pushed
the
mutation/09-1-handle-row-component-check
branch
from
September 6, 2026 12:56
c286af9 to
6878ca8
Compare
lovasoa
approved these changes
Sep 6, 2026
lovasoa
changed the title
lovasoa
approved these changes
Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handle_rowlooked up the current component's name and then only checked whether a component was open at all. The name was never read.found by #1396