feat: resolve annotations that are within Optional parameters - #3331
Merged
bnasslahsen merged 1 commit intoSep 6, 2026
Conversation
bnasslahsen
added a commit
that referenced
this pull request
Sep 6, 2026
JsonNullable<T> now renders as the wrapped value, nullable unless a non-null constraint applies, and no longer becomes required merely because such a constraint is present - the wrapper exists precisely to tell an omitted property apart from an explicit null. The converter is registered only when jackson-databind-nullable is on the classpath. The pull request's tests were renumbered to app271, since app270 was taken by PR #3331, and the jackson-databind-nullable version moved to a property in the root pom. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
bnasslahsen
pushed a commit
that referenced
this pull request
Sep 6, 2026
Constraints written on the type argument of an Optional parameter were dropped. Annotations are now read from every parameter's annotated type, through a guarded accessor that returns null instead of throwing when the method parameter has no index. Backport of PR #3331. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Mattias-Sehlstedt
deleted the
resolve-constraint-annotation-within-optional
branch
September 6, 2026 11:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add so that a validation constraint within an
Optionalin aparameteris introspected and applied to the schema