Fix duplicated tests - #37317
Draft
noojung wants to merge 1 commit into
Draft
Fix duplicated tests#37317noojung wants to merge 1 commit into
noojung wants to merge 1 commit into
Conversation
Signed-off-by: Hyunwoo Jung <hyunwoojung@kakao.com>
noojung
marked this pull request as draft
September 22, 2026 09:13
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found some tests that tested the same behavior.
This PR updates them to cover distinct scenarios or removes them when they are redundant.
JdbcTemplateTests:sqlUpdateWithThreadConnection()duplicatedsqlUpdate(). Bind a connection to the current thread and verify that it is reused without being closed.AnnotationExceptionHandlerMethodResolverTests:resolveMethodInherited()duplicatedresolveMethodFromAnnotation(). UseInheritedControllerto verify that exception handler annotations are found on overridden methods in the superclass.TransactionAwareConnectionFactoryProxyTests:getTargetConnectionShouldReturnTargetConnection()duplicatedunwrapShouldReturnTargetConnection(). CallConnectionFactoryUtils.getTargetConnection()instead ofunwrap().WebMvcStompWebSocketEndpointRegistrationTests:allowedOrigins()duplicatedsameOrigin(). Configure an explicit origin inallowedOrigins()and verify the interceptor's allowed origins in both tests.ExceptionHandlingWebHandlerTests:thrownExceptionBecomesErrorSignal()duplicatedhandleErrorSignal(). Enable the flag in thrownExceptionBecomesErrorSignal() to cover the catch (Throwable) block in ExceptionHandlingWebHandler. (supersedes Fix thrown exception setup in ExceptionHandlingWebHandlerTests #37233)StringMessageConverterTests: removefromMessageByteArray(), which duplicatedfromByteArrayMessage().SubProtocolWebSocketHandlerTests: removenoSubProtocolNoDefaultHandler(), which duplicatednoSubProtocolTwoHandlers().