Set SCIP document languages - #476
Merged
Merged
Conversation
eseliger
marked this pull request as ready for review
August 22, 2026 20:59
eseliger
marked this pull request as draft
August 22, 2026 21:08
eseliger
marked this pull request as ready for review
August 22, 2026 21:35
eseliger
marked this pull request as draft
August 22, 2026 22:07
eseliger
marked this pull request as ready for review
August 22, 2026 23:27
christoph-sg
force-pushed
the
document-language
branch
from
September 10, 2026 13:33
0c36373 to
79f78d9
Compare
christoph-sg
force-pushed
the
document-language
branch
from
September 11, 2026 08:58
79f78d9 to
4911003
Compare
christoph-sg
force-pushed
the
document-language
branch
from
September 11, 2026 09:03
4911003 to
251a9f6
Compare
christoph-sg
requested changes
Sep 11, 2026
christoph-sg
left a comment
christoph-sg
left a comment
Contributor
There was a problem hiding this comment.
Small change request. I'll implement it
| } | ||
| } | ||
|
|
||
| export function languageForFileName(fileName: string): string { |
Contributor
There was a problem hiding this comment.
Let's not return empty strings if we can't figure out the language, and return : string | undefined instead.
Amp-Thread-ID: https://ampcode.com/threads/T-01a08fb9-4268-777c-a54f-c96b172234a5 Co-authored-by: Amp <amp@ampcode.com>
christoph-sg
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements support for document language.
Closes #403.