Adopt path-based server function addressing - #590
Merged
Conversation
solidjs/solid#3076 moved the function id into the path (`<endpoint>/<id>`), retiring both the X-Server-Function-Id header and the `?id=` query fallback. The generic form-action fallback now reads the id back through the runtime's parseServerFunctionUrl rather than parsing the query by hand — the router no longer hard-codes the addressing scheme. Bound `?args` composition is untouched: arguments stayed in the query, and hashKey already emits the plain JSON the server-side convention reads. "Not an address" now means a malformed path (extra segments, bare endpoint) rather than a missing `?id`; the native-submission fallbacks keep working through the runtime's parse answering null. Requires @solidjs/web newer than 2.0.0-rc.3. Co-authored-by: Cursor <cursoragent@cursor.com>
🦋 Changeset detectedLatest commit: 701ccf8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
2 tasks
Member
Author
|
Companion plugin PR: solidjs/solid-vite-plugin#332 (endpoint prefix-matching + path-based module preload in the dev middleware). Both are draft until the next |
The dist-types check failed because the lockfile still resolved @solidjs/web 2.0.0-rc.3, which predates parseServerFunctionUrl — the runtime half of the addressing scheme this branch adopts. The peer and dev floors now say what the code means: ^2.0.0-rc.4. The vite plugin moves to 3.0.0-next.35 (the plugin half of solidjs/solid#3076), which requires vite 8, which requires vitest 4 — test-toolchain-only, but vitest 4 constructs `new FormData()` through the mock's implementation, so the arrow-function stubs become real functions (arrows aren't constructable), and one Mock type annotation gains its signature. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Downstream adoption of solidjs/solid#3076, which moved the server function id into the path (
<endpoint>/<id>) and retired both theX-Server-Function-Idheader and the?id=query fallback.createServerFormAction) reads the id back through the runtime's newparseServerFunctionUrlinstead of parsing?id=by hand — the router no longer hard-codes the addressing scheme.?argscomposition (action.with) is untouched: arguments stayed in the query per the #3072 discussion, andhashKeyalready emits the plain JSON the server-side convention decodes.?id; the native-submission fallbacks keep working through the runtime's parse answeringnull.actionBaseprefix interception is unchanged —/_server/<id>still lives under/_server.Draft until
@solidjs/webpublishes the addressing change (anything newer than2.0.0-rc.3). The^2.0.0-rc.3range picks the new build up on publish; CI here will fail on the missingparseServerFunctionUrlexport until then.Test plan
file:link to the@solidjs/webbuild from solidnext— 382 + 33 passing.@solidjs/webprerelease is published.Made with Cursor