Conversation
Adds a pivot-side profile-card guard so the protection no longer depends on an upstream Community Solid Server change: - GuardedWebIdStore extends the CSS BaseWebIdStore with hasWebId, an exact indexed lookup on the account storage; - ProfileCardGuard extends the CSS PassthroughStore and, for the card of a registered WebID, requires every write (PUT/POST or the result of a PATCH) to remain valid RDF that still contains the `<webId> solid:oidcIssuer <baseUrl/>` triple, and forbids deleting the card while its WebID is registered; - a new pivot config module wires the guard between the RDF patching store and the converting store, and routes the account/WebID key-value storage past it to avoid a dependency cycle; - the guard is enabled in the prod, suffix and dev server configs. Both classes extend types already present in the published @solid/community-server, so no CSS fork or patch is required. Adds unit and integration tests covering the full WebID lifecycle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a pivot-side profile-card guard so the protection no longer depends on an upstream Community Solid Server change:
<webId> solid:oidcIssuer <baseUrl/>triple, and forbids deleting the card while its WebID is registered;Both classes extend types already present in the published @solid/community-server, so no CSS fork or patch is required. Adds unit and integration tests covering the full WebID lifecycle.