WIP feat(T5): MRTR (multi round trip requests) types (#243) - #276
Draft
sideeffffect wants to merge 5 commits into
Draft
sideeffffect wants to merge 5 commits into
sideeffffect wants to merge 5 commits into
Conversation
…ue T8 (softwaremill#246) T3 (softwaremill#241): run client and server conformance at both 2025-11-25 and 2026-07-28 in CI (4 steps). Rename conformance-baseline.yml to conformance-baseline-2025-11-25.yml and add a client section to conformance-baseline-2026-07-28.yml (37 server, 37 client scenarios still failing, all needing later tickets). Both conformance tasks select the per-spec-version baseline from --requirements / --spec-version. Update both conformance READMEs with the two-revision and single-scenario commands. T8 (softwaremill#246): the modern-result envelope, server/discover and -32022 validation landed in softwaremill#260 (already on this base). Remaining server rules (-32602 missing _meta, -32020 header/_meta mismatch, HTTP 400/404 plain-JSON, notifications gating, server-context request facts, the test_missing_capability / test_logging_tool fixtures) are the WIP continuation tracked by this PR. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Add the 2026-07-28 subscription datatypes and their schema conformance tests: SubscriptionFilter, SubscriptionsListenParams/Request, SubscriptionsListenResult, SubscriptionsAcknowledgedParams and the acknowledged-notification wrapper. Add the reserved _meta key io.modelcontextprotocol/subscriptionId. Types only — serving is T8. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
) Add the 2026-07-28 shared metadata: - new Icon and Annotations types - icons on Implementation, ToolDefinition, Resource, ResourceTemplate, Prompt, ResourceLink - annotations and _meta on content blocks (Text/Image/Audio/ResourceContent) and Resource/ResourceTemplate - Implementation.websiteUrl/description, PromptReference.title, ResourceLink.title/size - server DSL builders (icons/annotations) on the resource, resource-template and prompt builders - schema conformance tests for the new fields against the 2026-07-28 schema All additive (optional, default None) so the 2025-11-25 wire is unchanged. Tool-builder `.icons(...)` deferred (threads through the multi-step Tool[I,O] chain); ToolDefinition still carries icons at the protocol level. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
9 tasks
…ange The mdoc client examples/quickstart matched ToolContent.Text with two patterns; T7 added annotations and _meta. Switch to a type pattern so the snippets survive further field additions. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Add the 2026-07-28 multi-round-trip request types: - InputRequest / InputResponse enums (sampling, roots, elicitation), discriminated by method / structural fields. - InputRequiredResult carrying pending InputRequests plus requestState and the modern result envelope (resultType defaults to incomplete). - ResultType gains the `incomplete` case. - ElicitParams becomes an enum with Form and Url variants (mode distinguishes them; optional on Form for 2025-11-25 back-compat). - CallToolParams / GetPromptParams / ReadResourceParams carry inputResponses and requestState so clients can resume a paused call. Schema conformance tests for the new modern defs; client-conformance elicitation handler updated for the ElicitParams enum. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
sideeffffect
force-pushed
the
feat/t5-mrtr-types
branch
from
September 23, 2026 18:04
1ff5094 to
807c8bc
Compare
This was referenced Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #243.
What
Adds the 2026-07-28 multi round trip request (MRTR) types — the machinery that lets a tool call pause, ask the client for input (sampling / roots / elicitation), and resume:
InputRequest/InputResponseenums (sampling, roots, elicitation), discriminated bymethod/ structural fields.InputRequiredResult— pendingInputRequests keyed by an opaque key, plusrequestStatethe client echoes back, and the modern result envelope (resultTypedefaults toincomplete).ResultTypegains theincompletecase.ElicitParamsbecomes an enum withFormandUrlvariants (modedistinguishes them; optional onFormfor 2025-11-25 back-compat).CallToolParams/GetPromptParams/ReadResourceParamscarryinputResponsesandrequestStateso a client can resume a paused call.Tests
$defs(ElicitRequestParamsurl variant,InputRequiredResult, the three request-params types).core/client/serverunit suites green.Stacking
This PR is stacked on #275 (T7); review only the T5 delta here:
sideeffffect/chimp@feat/t7-shared-types...feat/t5-mrtr-types
Stack (bottom → top, all on
2026-07-28-protocol-support)#271 (T3) → #273 (T6) → #275 (T7) → #276 (T5, this PR) → #274 (T8)
🤖 Generated with Claude Code