Skip to content

[E2E] Update flows to await console to hide - #4524

Open
j-piasecki wants to merge 1 commit into
mainfrom
push-nrxuxynosnyl
Open

j-piasecki wants to merge 1 commit into
mainfrom
push-nrxuxynosnyl

Conversation

@j-piasecki

Copy link
Copy Markdown
Member

Description

Updates flows to await close console button to be hidden after tapping it.

Test plan

CI

## Description

Updates flows to await close console button to be hidden after tapping it.

## Test plan

CI
Copilot AI lite review requested due to automatic review settings September 16, 2026 14:24
@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: c2ce1b1e-fa64-4515-ad4c-b8eb2734cf32

📥 Commits

Reviewing files that changed from the base of the PR and between 9fe2ff5 and 1101225.

📒 Files selected for processing (4)
  • .argent/flows/basic-long-press-test.yaml
  • .argent/flows/basic-tap-test.yaml
  • .argent/flows/nested-touchables-test.yaml
  • .argent/flows/shared-value-test.yaml

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Tests
    • Improved automated test reliability by waiting for the console close control to disappear before continuing.
    • Applied consistent close-transition checks across basic tap, long-press, nested touchable, and shared value test flows.

Walkthrough

Four test flows now wait for close-console-button to become hidden after each console-close tap.

Changes

Console close synchronization

Layer / File(s) Summary
Add console close waits
.argent/flows/basic-long-press-test.yaml, .argent/flows/basic-tap-test.yaml, .argent/flows/nested-touchables-test.yaml, .argent/flows/shared-value-test.yaml
Each console-close tap is followed by an await step that checks whether close-console-button is hidden before the flow continues.

Priority: ⚪ Not assessed

Merge Risk: ⚪ Minimal · up to 11012

The added waits align each console-close tap with the button becoming hidden, with no identified merge-blocking impact.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: updating end-to-end flows to wait for the console to hide after dismissal.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved review issues were identified.

Pull request overview

Updates E2E flows to wait for the console close button to be hidden after tapping it, preventing race conditions.

Changes:

  • Added hidden-state waits after console dismissal.
  • Updated four Argent flow files.
File summaries
File Description
.argent/flows/shared-value-test.yaml Adds console-close waits.
.argent/flows/nested-touchables-test.yaml Adds console-close waits.
.argent/flows/basic-tap-test.yaml Adds console-close waits.
.argent/flows/basic-long-press-test.yaml Adds console-close waits.
Review details
  • Files reviewed: 4/4 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants