[E2E] Update flows to await console to hide - #4524
j-piasecki wants to merge 1 commit into
Conversation
## Description Updates flows to await close console button to be hidden after tapping it. ## Test plan CI
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughFour test flows now wait for ChangesConsole close synchronization
Priority: ⚪ Not assessed Merge Risk: ⚪ Minimal · up to The added waits align each console-close tap with the button becoming hidden, with no identified merge-blocking impact. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified.
Pull request overview
Updates E2E flows to wait for the console close button to be hidden after tapping it, preventing race conditions.
Changes:
- Added hidden-state waits after console dismissal.
- Updated four Argent flow files.
File summaries
| File | Description |
|---|---|
.argent/flows/shared-value-test.yaml |
Adds console-close waits. |
.argent/flows/nested-touchables-test.yaml |
Adds console-close waits. |
.argent/flows/basic-tap-test.yaml |
Adds console-close waits. |
.argent/flows/basic-long-press-test.yaml |
Adds console-close waits. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Description
Updates flows to await close console button to be hidden after tapping it.
Test plan
CI