Return false from io_wait() for timeouts - #472
Merged
Merged
Conversation
Callers of `rb_io_wait()` expect a `false` return value for timeouts,
not nil. This could lead to very strange errors from code like
TCPSocket.new("192.0.2.1", 80, connect_timeout: 1)
which would raise
TypeError: no implicit conversion from nil to integer
It now raises the correct
IO::TimeoutError: user specified timeout for 192.0.2.1:80
tavianator
force-pushed
the
io-wait-timeout-false
branch
from
August 28, 2026 18:00
9c9ad0d to
83bd43e
Compare
Assisted-By: devx/5ab61f1c-bb1a-47a2-937a-b53ce39bb329
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Callers of
rb_io_wait()expect afalsereturn value for timeouts,not nil. This could lead to very strange errors from code like
which would raise
It now raises the correct
Types of Changes
Contribution