Skip to content

fix(search): clarify Atlassian setup and validate Confluence permissions - #7722

Merged
waleedlatif1 merged 3 commits into
stagingfrom
codex/atlassian-search-onboarding
Sep 10, 2026
Merged

waleedlatif1 merged 3 commits into
stagingfrom
codex/atlassian-search-onboarding

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Check Confluence permission and directory access during central Search setup, with bounded requests and a shared timeout.
  • Link to the correct token scope guide and clarify browsing accounts versus personal Search connections.
  • Show connection failures as toasts and simplify the Confluence, Jira, and service-account documentation.

Type of Change

  • Bug fix

Testing

  • 608 focused unit and disposable database integration tests passed; provider HTTP uses fixtures in automated integration tests.
  • Manually exercised live Confluence token setup, space selection, crawling, and search retrieval, plus Jira authorization and indexed issue retrieval.
  • TypeScript, lint, all 46 repository audits (including API validation), docs compilation, docs manifest, and block registry checks passed.
  • Live checks exercise the deployed version; automated tests cover the changes in this PR. Live permission-revocation testing remains outstanding.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 10, 2026 8:00am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with no new actionable findings and both prior bounded-sampling findings resolved and withdrawn.

Summary

  • Adds bounded Confluence directory, space-permission, restriction, role-assignment, and ancestor-access preflight checks.
  • Propagates enrollment and OAuth startup failures to user-visible notifications.
  • Clarifies Jira member-account Search and Confluence central-source setup.
  • Adds focused tests for permission validation, timeout behavior, response limits, and connection errors.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Admin configures Confluence source] --> B[Validate domain and selected spaces]
    B --> C[Run bounded permission preflight]
    C --> D[Check directory and group membership]
    C --> E[Check sampled space permissions and roles]
    C --> F[Check sampled content restrictions and ancestors]
    D --> G{Checks succeed within deadline?}
    E --> G
    F --> G
    G -->|Yes| H[Create source and begin sync]
    G -->|No| I[Show actionable connection error]
    H --> J[Verify each document ACL during sync]
    J --> K[Teammates connect personal identities for Search access]
Loading

Reviews (4) · Last reviewed commit: "chore(docs): clarify Confluence setup pe..."

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

Comment thread apps/sim/connectors/confluence/confluence.ts
@cubic-dev-ai

cubic-dev-ai Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

Comment thread apps/sim/connectors/confluence/confluence.ts
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@waleedlatif1
waleedlatif1 merged commit bc6b1b2 into staging Sep 10, 2026
33 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/atlassian-search-onboarding branch September 10, 2026 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant