fix(search): index only meetings from Google Calendar and mark declined invites - #7718
Merged
Merged
Conversation
…ed invites The listing never filtered by event type, so working-location, out-of-office, focus-time and birthday entries were indexed as documents. With recurring events expanded to instances, a daily working-location entry alone produced dozens of near-identical documents per member. The listing now asks Google for default events only and the connector drops any other type it still receives, including on a direct fetch. A shared calendar the member can read only as free/busy returns time blocks with no title or description, which were indexed as "Untitled Event". An event with neither is no longer a document. Invitations the connected account declined stay indexed, since the agenda and links are still something the person was sent, but the content now carries a "Response: declined" line and the metadata records the response. The metadata-only hash gains a declined suffix so already-indexed invitations pick the line up on the next sync without waiting for an edit. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
|
…ndees Only an event with no title, description, location, organizer and no attendees is the bare time block a free/busy reader receives. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
defaultevents only and drops any other type the API still returns (working location, out of office, focus time, birthdays), including on a direct event fetch. With recurring events expanded to instances, a daily status entry alone produced dozens of near-identical documents per memberResponse: declinedline plus aresponseStatusmetadata field; the metadata-only hash gains a declined suffix so already-indexed invitations pick it up on the next sync without waiting for an editType of Change
Testing
eventTypes=defaulton the listing request, status entries dropped from a listing and on direct fetch, free/busy placeholder withdrawn, declined invite marked with a distinct hashviteston the Calendar connector: 35 passingbun run type-check,bun run lint,bun run check:audits,docs-manifest:checkpassChecklist