Skip to content

fix(search): index only meetings from Google Calendar and mark declined invites - #7718

Merged
waleedlatif1 merged 2 commits into
stagingfrom
fix/google-calendar-search-noise
Sep 10, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
fix/google-calendar-search-noise

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Google Calendar listing now requests default events only and drops any other type the API still returns (working location, out of office, focus time, birthdays), including on a direct event fetch. With recurring events expanded to instances, a daily status entry alone produced dozens of near-identical documents per member
  • A free/busy-only time block (no title, no description) is no longer indexed as "Untitled Event"
  • Declined invitations stay searchable and now carry a Response: declined line plus a responseStatus metadata field; the metadata-only hash gains a declined suffix so already-indexed invitations pick it up on the next sync without waiting for an edit
  • Docs: Calendar Search page describes what is excluded and how declined invites appear

Type of Change

  • Bug fix

Testing

  • New tests: eventTypes=default on the listing request, status entries dropped from a listing and on direct fetch, free/busy placeholder withdrawn, declined invite marked with a distinct hash
  • vitest on the Calendar connector: 35 passing
  • bun run type-check, bun run lint, bun run check:audits, docs-manifest:check pass

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

…ed invites

The listing never filtered by event type, so working-location, out-of-office,
focus-time and birthday entries were indexed as documents. With recurring
events expanded to instances, a daily working-location entry alone produced
dozens of near-identical documents per member. The listing now asks Google
for default events only and the connector drops any other type it still
receives, including on a direct fetch.

A shared calendar the member can read only as free/busy returns time blocks
with no title or description, which were indexed as "Untitled Event". An
event with neither is no longer a document.

Invitations the connected account declined stay indexed, since the agenda
and links are still something the person was sent, but the content now
carries a "Response: declined" line and the metadata records the response.
The metadata-only hash gains a declined suffix so already-indexed
invitations pick the line up on the next sync without waiting for an edit.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@vercel

vercel Bot commented Sep 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 10, 2026 5:55am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with the prior untitled-meeting regression fully addressed and no actionable new issue established.

Summary

  • Requests and accepts only default Calendar event types.
  • Preserves untitled meetings when they still contain a location, organizer, or attendees.
  • Adds declined-response content, metadata, and hash invalidation.
  • Documents the revised indexing behavior.
  • The previously reported untitled-meeting issue is fixed, covered by tests, and its thread is resolved.

Reviews (2) · Last reviewed commit: "fix(search): keep untitled Calendar meet..."

Comment thread apps/sim/connectors/google-calendar/google-calendar.ts Outdated
…ndees

Only an event with no title, description, location, organizer and no
attendees is the bare time block a free/busy reader receives.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@waleedlatif1
waleedlatif1 merged commit b6d1da4 into staging Sep 10, 2026
25 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/google-calendar-search-noise branch September 10, 2026 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant