Skip to content

fix(search): clarify source settings and permission updates - #7715

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/search-settings-final-polish
Sep 10, 2026
Merged

fix(search): clarify source settings and permission updates#7715
waleedlatif1 merged 2 commits into
stagingfrom
codex/search-settings-final-polish

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Move OAuth configuration maintenance out of the Sources toolbar into a clearly named overflow action with a reconnect confirmation.
  • Remove the member Integrations shortcut from admin Accounts empty states; update setup guidance and the Sources screenshot.
  • Preserve unknown Confluence grant scopes so existing workflow credentials correctly offer Update access.

Type of Change

  • Bug fix

Testing

  • 336 focused tests passed, including scope projection, existing grants, Box fallback, refresh confirmation, provider setup and source settings.
  • 83 additional staging integration checks passed across UI, connection hooks and cache reset (partly overlapping the focused suites).
  • Verified Sources menu/confirmation/cancel and Calendar Accounts in the local UI.
  • Full lint, typecheck across 26 workspaces, all 46 CI audits, generated artifacts, docs validation and cleanup passed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 10, 2026 3:21am UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile-apps Please review the updated PR.

@waleedlatif1
waleedlatif1 force-pushed the codex/search-settings-final-polish branch from 9a5c3db to befdfaf Compare September 10, 2026 03:18
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@greptile-apps

greptile-apps Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with no outstanding actionable findings.

Summary

  • Moves provider configuration refresh into a confirmed Sources overflow action with retryable error handling.
  • Preserves actual Confluence grant scopes while retaining the omitted-scope fallback for providers such as Box.
  • Removes the member-facing Integrations shortcut from organization account empty states.
  • Updates recovery guidance and Search documentation to cover both Search-enabled and Search-disabled layouts.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Deployment OAuth settings change] --> B{Search enabled?}
  B -->|Yes| C[Sources → More → Refresh connection settings]
  B -->|No| D[Connected accounts → Providers → Update configurations]
  C --> E[Apply current provider settings]
  D --> E
  E --> F[Affected users reconnect]
Loading

Reviews (3) · Last reviewed commit: "fix(search): clarify recovery when Searc..."

Comment thread apps/sim/lib/credential-groups/service.ts Outdated
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile-apps Please review the updated PR.

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@waleedlatif1
waleedlatif1 merged commit 216b199 into staging Sep 10, 2026
33 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/search-settings-final-polish branch September 10, 2026 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant