feat(slack): improve source connections and app Home - #7676
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
@cubic-dev-ai review this PR |
@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete. |
Greptile SummaryThis PR improves the Slack Search integration by adding a persistent static App Home, supporting removal of organization Slack account setup, refreshing related organization-scoped caches, and displaying verified citations inline in streamed answers.
Confidence Score: 5/5The PR appears safe to merge, with no actionable new defects or outstanding previous findings identified. The static Home shortcut performs no protected work, publication revalidates installation bindings, account removal preserves non-Slack options and refreshes relevant caches, and inline citations are derived only from verified retrieval evidence. The prior documentation finding was resolved after Greptile agreed the TSDoc convention had been over-applied.
|
| Filename | Overview |
|---|---|
| apps/sim/lib/knowledge/application/slack-search/home.ts | Adds bounded, binding-aware intake and publication for the static Slack Home view. |
| apps/sim/lib/slack-search/home.ts | Parses Home events, derives an opaque persistent view marker, and renders the static Home layout. |
| apps/sim/lib/slack-search/assistant-stream.ts | Resolves verified retrieval citations inline while preserving streaming safety and secret projection. |
| apps/sim/app/o/[organizationId]/settings/components/integrations/slack-account-removal.tsx | Adds confirmed removal of Slack options from an organization credential group. |
| apps/sim/app/o/[organizationId]/settings/integrations/providers/[connectorType]/provider-detail.tsx | Exposes Slack setup removal from source and account management views. |
| apps/sim/hooks/queries/organization-accounts.ts | Invalidates organization account, Slack manifest, and search overview caches after updates. |
| apps/sim/lib/knowledge/application/authorized-knowledge-use-case.ts | Simplifies delegated-principal typing while runtime authorization continues to enforce service-specific access. |
Sequence Diagram
sequenceDiagram
participant Slack
participant Ingress as Slack ingress
participant Home as Home use case
participant Queue as Inline job queue
participant API as Slack API
participant Sim as Sim integrations page
Slack->>Ingress: app_home_opened
Ingress->>Home: Verified installation principal and view marker
alt Current marker
Home-->>Slack: Acknowledge without publication
else First visit or stale marker
Home->>Queue: Enqueue deduplicated Home publication
Queue->>Home: Run with revalidated installation binding
Home->>API: views.publish static Home
API-->>Slack: Store Home view and callback marker
end
Slack->>Sim: User selects Connect sources
Sim-->>Slack: Authorize and show organization integrations
Reviews (4): Last reviewed commit: "improvement(slack): simplify Home to a p..." | Re-trigger Greptile
|
@cubic-dev-ai review this PR |
@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete. |
|
@cubic-dev-ai review this PR |
@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete. |
|
@cubic-dev-ai review this PR |
@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete. |
Summary
Type of Change
Testing
Checklist