Skip to content

feat(slack): improve source connections and app Home - #7676

Merged
TheodoreSpeaks merged 4 commits into
stagingfrom
codex/slack-source-account-removal
Sep 9, 2026
Merged

feat(slack): improve source connections and app Home#7676
TheodoreSpeaks merged 4 commits into
stagingfrom
codex/slack-source-account-removal

Conversation

@TheodoreSpeaks

@TheodoreSpeaks TheodoreSpeaks commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add a persistent Slack Home tab with a Connect sources button linking to the existing Sim Integrations page. Publish on first visits and when the saved layout, credential, or app origin changes; current views skip Home lookup, queue, and publish work.
  • Keep Home static: no source-status queries, Slack email lookup, or invitation links. Recheck installation bindings before publishing and let Sim authorize access to the destination. Enable Home in the setup manifest without adding scopes.
  • Expose Slack account setup removal from Sources and Accounts, preserving other providers and refreshing organization-scoped setup caches.
  • Render verified citations inline beside the answer text and remove the trailing source footer.

Type of Change

  • Feature
  • Bug fix

Testing

  • 340 focused tests across 27 suites passed, including Home routing, saved-view reuse and invalidation, installation isolation, cancellation, failed delivery, existing Slack ingress, and Assistant behavior.
  • App/auth typechecks, lint, all 46 repository audits, block registry, and docs manifest checks passed.
  • Earlier account-removal validation passed 176 tests across 11 suites.
  • The Home tab and new inline citation presentation have not been smoke-tested in live Slack. Existing apps need Home enabled in their Slack configuration.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 9, 2026 9:09pm UTC

Request Review

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@greptile

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete.

@greptile-apps

greptile-apps Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR improves the Slack Search integration by adding a persistent static App Home, supporting removal of organization Slack account setup, refreshing related organization-scoped caches, and displaying verified citations inline in streamed answers.

  • Publishes and reuses a static Slack Home view linked to Sim’s organization integrations page.
  • Adds Slack account-setup removal controls while preserving other provider options.
  • Extracts shared search-source query keys and expands targeted cache invalidation.
  • Replaces trailing source blocks with verified inline citation links.
  • Simplifies Slack Search organization delegation after removing personalized Home source queries.

Confidence Score: 5/5

The PR appears safe to merge, with no actionable new defects or outstanding previous findings identified.

The static Home shortcut performs no protected work, publication revalidates installation bindings, account removal preserves non-Slack options and refreshes relevant caches, and inline citations are derived only from verified retrieval evidence. The prior documentation finding was resolved after Greptile agreed the TSDoc convention had been over-applied.

Important Files Changed

Filename Overview
apps/sim/lib/knowledge/application/slack-search/home.ts Adds bounded, binding-aware intake and publication for the static Slack Home view.
apps/sim/lib/slack-search/home.ts Parses Home events, derives an opaque persistent view marker, and renders the static Home layout.
apps/sim/lib/slack-search/assistant-stream.ts Resolves verified retrieval citations inline while preserving streaming safety and secret projection.
apps/sim/app/o/[organizationId]/settings/components/integrations/slack-account-removal.tsx Adds confirmed removal of Slack options from an organization credential group.
apps/sim/app/o/[organizationId]/settings/integrations/providers/[connectorType]/provider-detail.tsx Exposes Slack setup removal from source and account management views.
apps/sim/hooks/queries/organization-accounts.ts Invalidates organization account, Slack manifest, and search overview caches after updates.
apps/sim/lib/knowledge/application/authorized-knowledge-use-case.ts Simplifies delegated-principal typing while runtime authorization continues to enforce service-specific access.

Sequence Diagram

sequenceDiagram
    participant Slack
    participant Ingress as Slack ingress
    participant Home as Home use case
    participant Queue as Inline job queue
    participant API as Slack API
    participant Sim as Sim integrations page

    Slack->>Ingress: app_home_opened
    Ingress->>Home: Verified installation principal and view marker
    alt Current marker
        Home-->>Slack: Acknowledge without publication
    else First visit or stale marker
        Home->>Queue: Enqueue deduplicated Home publication
        Queue->>Home: Run with revalidated installation binding
        Home->>API: views.publish static Home
        API-->>Slack: Store Home view and callback marker
    end
    Slack->>Sim: User selects Connect sources
    Sim-->>Slack: Authorize and show organization integrations
Loading

Reviews (4): Last reviewed commit: "improvement(slack): simplify Home to a p..." | Re-trigger Greptile

@TheodoreSpeaks TheodoreSpeaks changed the title fix(slack): expose account setup removal in sources fix(slack): improve account recovery and inline citations Sep 9, 2026
@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@greptile

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete.

@TheodoreSpeaks TheodoreSpeaks changed the title fix(slack): improve account recovery and inline citations feat(slack): improve source connections and app Home Sep 9, 2026
@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@greptile

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete.

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@greptile

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete.

@TheodoreSpeaks
TheodoreSpeaks merged commit b31651e into staging Sep 9, 2026
59 of 61 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/slack-source-account-removal branch September 9, 2026 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant