Skip to content

fix(slack): return one conversation page with next cursor - #7611

Merged
TheodoreSpeaks merged 2 commits into
stagingfrom
fix/slack-v2-pagination-fix
Sep 8, 2026
Merged

fix(slack): return one conversation page with next cursor#7611
TheodoreSpeaks merged 2 commits into
stagingfrom
fix/slack-v2-pagination-fix

Conversation

@TheodoreSpeaks

@TheodoreSpeaks TheodoreSpeaks commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Stop auto-pagination in Slack v2 List Channels to avoid bursts of API requests. Each call returns one page with nextCursor and hasMore so callers can request the next page explicitly.
  • Remove Max Pages and the redundant pages output, migrate saved settings, and refresh the tool metadata and docs.

Type of Change

  • Bug fix

Testing

96 targeted tests pass, including cursor resumption, empty pages with a cursor, rate-limit errors, and saved-workflow migrations. Full lint, repository audits, block registry validation, and docs manifest checks pass.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 8, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 8, 2026 9:44pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge; the single-page cursor contract is consistently implemented, migrated, documented, and tested.

Summary

  • Performs exactly one conversations.list request per invocation.
  • Returns nextCursor and hasMore so callers can request subsequent pages.
  • Removes the retired maxPages input and constant pages output.
  • Migrates saved Slack block settings to remove channelMaxPages.
  • Updates tests, generated metadata, deployment configuration, and documentation to match the new contract.

Diagram

sequenceDiagram
    participant Caller
    participant Sim as Slack List Channels
    participant Slack as Slack API

    Caller->>Sim: list channels(limit, optional cursor)
    Sim->>Slack: conversations.list(limit, cursor)
    Slack-->>Sim: channels + next_cursor
    Sim-->>Caller: channels, count, hasMore, nextCursor

    opt hasMore is true
        Caller->>Sim: list channels(limit, nextCursor)
        Sim->>Slack: conversations.list(limit, nextCursor)
        Slack-->>Sim: next page + next_cursor
        Sim-->>Caller: next page, hasMore, nextCursor
    end
Loading

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@greptile

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete.

@TheodoreSpeaks
TheodoreSpeaks merged commit 4e6ee86 into staging Sep 8, 2026
33 of 34 checks passed
@TheodoreSpeaks
TheodoreSpeaks deleted the fix/slack-v2-pagination-fix branch September 8, 2026 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant