feat(oci): add native foundation by BillLeoutsakosvl346 · Pull Request #7444 · simstudioai/sim

BillLeoutsakosvl346 · 2026-09-03T20:25:22Z

Summary

Add a server-only OCI API-key credential foundation with strict validation, in-memory request signing, safe endpoint resolution, bounded transport, and sanitized errors.
Snapshot the OCI region/realm registry while deferring Queue, public credential plumbing, UI, catalog, icons, docs, and generated API changes.
Pin oci-common 2.140.0, the newest release allowed by the repository dependency-age gate; its region/realm registry is byte-identical to 2.140.1.

Type of Change

Testing

Node 22 focused Vitest suite: 65 tests passed
Bun 1.3.14 focused Vitest suite: 65 tests passed
Workspace type-check and production Sim build
Lint, block-registry checks, all 45 repository audits, and docs-manifest check

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Screenshots/Videos

Not applicable; this change is server-only.

vercel · 2026-09-03T20:25:28Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Sep 4, 2026 7:44pm UTC

greptile-apps · 2026-09-03T20:28:20Z

Greptile Summary

The PR introduces native server-side OCI API-key credential support, including validation, request signing, endpoint resolution, encrypted storage, API contracts, and setup UI.

Adds OCI credential creation and full-tuple rotation flows.
Adds bounded OCI transport and a snapshotted region/realm registry.
Extends public credential contracts, generated CLI types, documentation, and focused tests.

Confidence Score: 5/5

The PR appears safe to merge because no blocking failure remains in the eligible follow-up review scope.

No blocking failure remains.

Important Files Changed

Filename	Overview
apps/sim/lib/internal/oci/client.server.ts	Implements server-only OCI credential parsing, Signature v1 request signing, bounded transport, and setup verification.
apps/sim/lib/internal/oci/endpoints.ts	Adds a fixed OCI region/realm registry and strict service-endpoint validation.
apps/sim/lib/credentials/oci-api-key-service-account.server.ts	Validates OCI API-key material, verifies it against OCI, sanitizes failures, and encrypts the resulting secret.
apps/sim/lib/credentials/orchestration/index.ts	Integrates OCI fields into credential updates and enforces complete credential tuples during rotation.
apps/sim/lib/credentials/orchestration/credential-create.ts	Integrates OCI verification and sanitized provider errors into credential creation.
apps/sim/lib/api/contracts/v2/credentials.ts	Extends V2 credential contracts with OCI identifiers, region, private key, and optional passphrase fields.
apps/sim/app/workspace/[workspaceId]/integrations/components/connect-service-account-modal/connect-service-account-modal.tsx	Adds the OCI API-key setup and reconnect form with required-field checks and secret inputs.
apps/sim/lib/credentials/service-account-secret.ts	Registers OCI as a supported service-account secret provider and routes its fields through verification.
packages/sim-cli/src/generated/v2-api.ts	Updates generated CLI API types to expose the new write-only OCI credential fields.

Sequence Diagram

sequenceDiagram
  participant User
  participant API as Credential API
  participant Validator as OCI Credential Validator
  participant OCI as OCI GetNamespace
  participant Store as Encrypted Credential Store
  User->>API: Submit OCI API-key fields
  API->>Validator: Validate OCIDs, region, fingerprint, and RSA key
  Validator->>OCI: Send signed, bounded GetNamespace request
  OCI-->>Validator: Return namespace
  Validator->>Store: Encrypt and persist validated credential
  Store-->>API: Return sanitized credential metadata
  API-->>User: Credential created or rotated

_{Reviews (17): Last reviewed commit: "fix(oci): preserve transport size errors" | Re-trigger Greptile}

cubic-dev-ai

All reported issues were addressed across 12 files

_{Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-03T20:41:23Z

@greptile review this PR

BillLeoutsakosvl346 · 2026-09-03T20:41:23Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-03T20:41:29Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 12 files

_{Fix all with cubic | Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-03T21:10:39Z

@greptile review this PR

BillLeoutsakosvl346 · 2026-09-03T21:10:40Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-03T21:10:46Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 12 files

_{Fix all with cubic | Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-03T21:28:59Z

@greptile review this PR

BillLeoutsakosvl346 · 2026-09-03T21:29:00Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-03T21:29:05Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 12 files

_{Fix all with cubic | Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-03T21:45:55Z

@greptile review this PR

BillLeoutsakosvl346 · 2026-09-03T21:45:56Z

@cubic-dev-ai review this PR

BillLeoutsakosvl346 · 2026-09-04T17:21:10Z

@greptile

BillLeoutsakosvl346 · 2026-09-04T17:21:14Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-04T17:21:19Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 38 files

_{You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Fix all with cubic | Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-04T17:30:21Z

@greptile

BillLeoutsakosvl346 · 2026-09-04T17:30:25Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-04T17:30:33Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 38 files

_{You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Fix all with cubic | Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-04T17:39:38Z

@greptile

BillLeoutsakosvl346 · 2026-09-04T17:39:41Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-04T17:39:48Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 38 files

_{You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Fix all with cubic | Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-04T19:34:27Z

@greptile

BillLeoutsakosvl346 · 2026-09-04T19:34:31Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-04T19:34:37Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 36 files

_{You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Fix all with cubic | Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-04T19:46:43Z

@greptile

BillLeoutsakosvl346 · 2026-09-04T19:46:46Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-04T19:46:54Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 36 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Re-trigger cubic}

BillLeoutsakosvl346 requested a review from a team as a code owner September 3, 2026 20:25

vercel Bot deployed to Preview September 3, 2026 20:27 View deployment

cubic-dev-ai Bot reviewed Sep 3, 2026

View reviewed changes

Comment thread apps/sim/lib/internal/oci/endpoints.ts Outdated

Comment thread apps/sim/lib/internal/oci/errors.ts Outdated

Comment thread apps/sim/lib/internal/oci/endpoints.ts Outdated

BillLeoutsakosvl346 force-pushed the feat/oci-foundation branch from d7a3b4f to d2d066d Compare September 3, 2026 20:40

vercel Bot deployed to Preview September 3, 2026 20:42 View deployment

cubic-dev-ai Bot reviewed Sep 3, 2026

View reviewed changes

Comment thread apps/sim/lib/internal/oci/errors.ts Outdated

Comment thread apps/sim/lib/internal/oci/errors.ts Outdated

Comment thread apps/sim/lib/internal/oci/errors.ts Outdated

Comment thread apps/sim/lib/internal/oci/errors.ts Outdated

BillLeoutsakosvl346 force-pushed the feat/oci-foundation branch from d2d066d to 77e26a0 Compare September 3, 2026 21:10

vercel Bot deployed to Preview September 3, 2026 21:12 View deployment

cubic-dev-ai Bot reviewed Sep 3, 2026

View reviewed changes

Comment thread apps/sim/lib/internal/oci/errors.ts Outdated

Comment thread apps/sim/lib/internal/oci/errors.ts Outdated

Comment thread apps/sim/lib/internal/oci/errors.ts Outdated

vercel Bot temporarily deployed to Preview September 3, 2026 21:28 Inactive

cubic-dev-ai Bot reviewed Sep 3, 2026

View reviewed changes

Comment thread apps/sim/lib/internal/oci/client.server.ts

Comment thread apps/sim/lib/internal/oci/errors.ts Outdated

Comment thread apps/sim/lib/internal/oci/client.server.ts Outdated

Comment thread apps/sim/lib/internal/oci/client.server.test.ts Outdated

BillLeoutsakosvl346 added 5 commits September 3, 2026 14:41

feat(oci): add native foundation

017b916

fix(oci): harden endpoint and error validation

729cd14

fix(oci): fail closed on encoded diagnostics

da17132

fix(oci): reject ambiguous diagnostics

47f8461

fix(oci): harden signed request boundaries

a48813a

BillLeoutsakosvl346 force-pushed the feat/oci-foundation branch from b1c7879 to a48813a Compare September 3, 2026 21:45

vercel Bot temporarily deployed to Preview September 4, 2026 17:20 Inactive

cubic-dev-ai Bot reviewed Sep 4, 2026

View reviewed changes

Comment thread apps/sim/lib/internal/oci/client.server.ts Outdated

fix(oci): enforce destination validation deadlines

f5df063

vercel Bot temporarily deployed to Preview September 4, 2026 17:30 Inactive

cubic-dev-ai Bot reviewed Sep 4, 2026

View reviewed changes

Comment thread apps/sim/lib/internal/oci/client.server.ts Outdated

fix(oci): stop requests after DNS deadlines

25ad712

vercel Bot temporarily deployed to Preview September 4, 2026 17:39 Inactive

cubic-dev-ai Bot reviewed Sep 4, 2026

View reviewed changes

Comment thread apps/sim/lib/internal/oci/client.server.ts

Bill Leoutsakos added 2 commits September 4, 2026 12:25

refactor(oci): remove shared credential hardening

e1039f2

fix(oci): tighten request lifecycle

d843e63

vercel Bot temporarily deployed to Preview September 4, 2026 19:34 Inactive

cubic-dev-ai Bot reviewed Sep 4, 2026

View reviewed changes

Comment thread apps/sim/lib/credentials/service-account-secret.ts

Comment thread apps/sim/lib/internal/oci/client.server.ts

fix(oci): preserve transport size errors

b51236f

vercel Bot temporarily deployed to Preview September 4, 2026 19:44 Inactive

cubic-dev-ai Bot reviewed Sep 4, 2026

View reviewed changes

Uh oh!

Conversation

BillLeoutsakosvl346 commented Sep 3, 2026

Summary

Type of Change

Testing

Checklist

Screenshots/Videos

Uh oh!

vercel Bot commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps Bot commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Sequence Diagram

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Sep 3, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 3, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 3, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Sep 3, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 3, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 3, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Sep 3, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 3, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 3, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Sep 3, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 3, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 4, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 4, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 4, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

vercel Bot commented Sep 3, 2026 •

edited

Loading

greptile-apps Bot commented Sep 3, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading