fix(pdf): keep PDF.js external in production - #7409
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryThe PR keeps
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| apps/sim/next.config.ts | Adds pdfjs-dist to the server external-package list, preserving its runtime package layout. |
| apps/sim/next.config.test.ts | Adds a discoverable Node-environment regression test and resolves the previously reported filename mismatch. |
Reviews (2): Last reviewed commit: "chore(pdf): align config test filename" | Re-trigger Greptile
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@j15z I have started the AI code review. It will take a few minutes to complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
bun run test next-config.test.ts lib/file-parsers/pdfjs-server.test.ts lib/file-parsers/pdf-parser.test.ts(9 tests passed)bun run lintbun run apps/sim/scripts/check-block-registry.ts origin/stagingbun run check:audits(45 audits passed)bun run docs-manifest:checkChecklist