fix(docker): allow pruned lockfile normalization - #7350
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Greptile SummaryThis PR allows Bun to normalize the full root lockfile when installing dependencies from partial workspace manifests while retaining full-repository frozen-lockfile validation in CI.
Confidence Score: 5/5The PR appears safe to merge with no concrete blocking or non-blocking issues identified. The changed Docker stages deliberately permit Bun to remove unrelated workspace entries from the full lockfile, while full-repository CI retains the canonical frozen-lockfile consistency check.
|
| Filename | Overview |
|---|---|
| docker/app.Dockerfile | Allows expected lockfile normalization for the Turbo-pruned application graph; no actionable defect was established. |
| docker/db.Dockerfile | Allows expected lockfile normalization for the closed migration workspace subset; no actionable defect was established. |
Reviews (1): Last reviewed commit: "fix(docker): allow pruned lockfile norma..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
PR #7343 added frozen-lockfile enforcement to Docker stages that intentionally copy only a subset of workspace manifests. The root bun.lock describes every workspace, so Bun 1.3.14 needs to remove unrelated workspace entries before installing the app or migration dependency graph. Freezing that expected normalization caused both image builds to fail with "lockfile had changes, but lockfile is frozen" and skipped image promotion.
Failed run: https://github.com/simstudioai/sim/actions/runs/33493411083/job/99810890876
Regression commit: fd061f5
Verification