Skip to content

fix(selectors): normalize Bitbucket workspace UUIDs - #7320

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/bitbucket-workspace-uuid-canonicalization
Sep 1, 2026
Merged

fix(selectors): normalize Bitbucket workspace UUIDs#7320
waleedlatif1 merged 1 commit into
stagingfrom
fix/bitbucket-workspace-uuid-canonicalization

Conversation

@BillLeoutsakosvl346

@BillLeoutsakosvl346 BillLeoutsakosvl346 commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Normalizes UUID-shaped Bitbucket workspace identifiers into Bitbucket Cloud canonical braced form for provider lookup.
  • Leaves saved workspace slugs, UUIDs, and environment references unchanged.
  • Extends the existing adapter behavior test to cover both braced and unbraced UUID input.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Other

Testing

  • bun run --cwd apps/sim test lib/selectors/server/providers/bitbucket.test.ts
  • bun run --cwd apps/sim type-check
  • bun run check:api-validation:strict
  • bun run check:fork-dependent-coverage
  • bun run check:client-boundary
  • git diff --check

Browser verification was not performed; it was waived for this focused server-side change.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement

Screenshots/Videos

Not applicable; there are no UI changes.

@vercel

vercel Bot commented Aug 31, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Aug 31, 2026 11:40pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR canonicalizes UUID-shaped Bitbucket workspace identifiers into lowercase, braced form only when constructing provider lookup requests, while preserving saved identifiers and environment references.

  • Adds a dedicated formatter for Bitbucket workspace UUID lookup paths.
  • Resolves both braced and unbraced workspace UUIDs through the canonical provider URL.
  • Extends adapter tests to cover both input forms.

Confidence Score: 5/5

The PR appears safe to merge with no actionable correctness, security, or maintainability issues identified.

The formatter is reached only for values already validated as UUIDs, produces Bitbucket’s canonical braced lowercase representation, and leaves slug handling and selector identity preservation unchanged.

Important Files Changed

Filename Overview
apps/sim/lib/selectors/server/providers/bitbucket.ts Canonicalizes validated workspace UUIDs for Bitbucket API lookup without changing persisted or returned selector identifiers.
apps/sim/lib/selectors/server/providers/bitbucket.test.ts Parameterizes workspace UUID resolution coverage for braced and unbraced inputs and verifies the canonical provider path.

Reviews (1): Last reviewed commit: "fix(selectors): normalize Bitbucket work..." | Re-trigger Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Heads up: you’re close to your included review allowance. Set a flex budget so reviews don’t pause.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit bd7995e into staging Sep 1, 2026
28 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/bitbucket-workspace-uuid-canonicalization branch September 1, 2026 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants