chore(skills): name directExecution as retired in the add-integration checklist - #7236
Merged
Merged
Conversation
… checklist The transport checklist listed the property inside a bare enumeration -- "declares `request.internal`, or `directExecution`, or has an HTTP fallback" -- which stacks two disjunctions and drops the "retired" framing every other statement of this rule carries, including line 71 of the same file and the add-tools, add-trigger, and add-block skills. A reader scanning the checklist could take it for a property that still exists and is merely discouraged. Wording only; the rule itself is unchanged and is enforced by check:tool-request-boundary.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Greptile SummaryThis documentation-only PR clarifies that
Confidence Score: 5/5The PR appears safe to merge because it only clarifies existing documentation and introduces no actionable issue. The revised checklist preserves the existing tool-boundary requirements while accurately identifying directExecution as retired.
|
| Filename | Overview |
|---|---|
| .agents/skills/add-integration/SKILL.md | Clarifies existing checklist terminology consistently with the mechanically enforced tool-request boundary. |
Reviews (1): Last reviewed commit: "chore(skills): name directExecution as r..." | Re-trigger Greptile
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the
directExecutionretirement, from a review finding on the v0.8.16 release PR (#7224).The add-integration transport checklist listed the property inside a bare enumeration:
That stacks two disjunctions and drops the "retired" framing every other statement of the same rule carries — including line 71 of this very file, and the
add-tools,add-trigger, andadd-blockskills. A reader scanning the checklist could reasonably takedirectExecutionfor a property that still exists and is merely discouraged, which is the opposite of the intent.Now reads:
Wording only. The rule itself is unchanged, and it is enforced mechanically by
check:tool-request-boundary, which fails withdirectExecution is retired; use InternalToolConfig.operation and a registered server handler.Checks
bun run lint— cleanbun run check:audits— 39/39 pass (includescheck:skillsandcheck:tool-request-boundary)check-block-registry.ts origin/staging— passskills:sync+agent-stream-docs:generate— no artifact drift