fix(connectors): honor provider retry deadlines

[waleedlatif1]

Summary

• preserve upstream retry deadlines after an in-process retry budget exits so scheduled connector syncs do not retry before provider resets
• share bounded retry-error construction and surface rate-limit failures without exposing provider response bodies
• distinguish empty Atlassian site grants from malformed discovery responses with actionable reconnect guidance

Type of Change

• Bug fix

Testing

• 313 targeted connector, retry, and discovery tests
• bun run type-check in apps/sim
• bun run lint
• bun run check:audits (38/38)

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Aug 28, 2026 9:10am

[greptile-apps]

Greptile Summary

The PR preserves validated provider retry deadlines when scheduling failed connector syncs, centralizes sanitized retryable HTTP error construction, and improves Atlassian discovery diagnostics.

• Applies provider retry deadlines as a bounded lower limit on connector failure backoff.
• Cancels omitted rate-limit response bodies before creating sanitized errors.
• Validates Atlassian accessible-resource entries and distinguishes malformed responses from empty grants.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename	Overview
apps/sim/lib/atlassian/discovery.ts	Validates accessible-resource entries before selection and gives distinct diagnostics for malformed payloads and credentials with no site grants.
apps/sim/lib/knowledge/connectors/sync-engine.ts	Propagates validated retry delays through connector failures and bounds scheduling between the existing failure ladder and one-day ceiling.
apps/sim/lib/knowledge/documents/utils.ts	Centralizes bounded retryable HTTP error creation, sanitizes rate-limit diagnostics, cancels omitted bodies, and exposes retry delays through error cause chains.
apps/sim/lib/knowledge/documents/secure-fetch.server.ts	Reuses the shared retryable HTTP error builder for SSRF-safe connector requests.
apps/sim/lib/knowledge/documents/utils.test.ts	Covers sanitized rate-limit errors, response-body cancellation, retry-deadline extraction, and invalid deadline rejection.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Connector HTTP request] --> B{Retryable response?}
  B -- No --> C[Return response]
  B -- Yes --> D{Rate limited?}
  D -- Yes --> E[Cancel response body]
  D -- No --> F[Read bounded diagnostic body]
  E --> G[Create sanitized HTTP error]
  F --> G
  G --> H[Attach validated retry deadline]
  H --> I[In-process retry budget]
  I --> J{Eventually succeeds?}
  J -- Yes --> K[Complete sync]
  J -- No --> L[Connector failure update]
  L --> M[Schedule at max of failure backoff and bounded provider deadline]

Loading

_{Reviews (2): Last reviewed commit: "fix(connectors): validate retry response..." | Re-trigger Greptile}

[cubic-dev-ai]

All reported issues were addressed across 7 files

<sub>Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic</sub>

[waleedlatif1]

@cubic

[waleedlatif1]

@greptile

[cubic-dev-ai]

@cubic

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

[cubic-dev-ai]

No issues found across 7 files

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

_{Re-trigger cubic}