improvement(tables): simplify column dropdown - #7193
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryThe PR simplifies and renames the table column dropdown while presenting Enrichments after the standard column options.
Confidence Score: 5/5The PR appears safe to merge with no actionable correctness, security, or quality issues identified. The renamed exports are updated consistently across all consumers, and the shared dropdown’s scrollable height accommodates the complete nine-item menu.
|
| Filename | Overview |
|---|---|
| apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/column-dropdown/column-dropdown.tsx | Renames the component and integrates Enrichments into the standard dropdown list without introducing a concrete behavioral defect. |
| apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/column-dropdown/column-dropdown.test.tsx | Adds focused coverage for option order, separator removal, and Enrichments selection. |
| apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/table-grid.tsx | Updates the inline table-header consumer to the renamed dropdown and applies behavior-neutral formatting. |
| apps/sim/app/workspace/[workspaceId]/tables/[tableId]/table.tsx | Updates the page-header consumer to use the renamed barrel export. |
| apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/column-config-sidebar/column-types.ts | Stops exporting internal option types that have no remaining external consumers. |
Reviews (1): Last reviewed commit: "improvement(tables): simplify column dro..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
bun run lintbun run check:auditsbunx turbo run type-checkbun run testChecklist