Skip to content

improvement(tables): simplify column dropdown - #7193

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/column-dropdown-cleanup
Aug 28, 2026
Merged

improvement(tables): simplify column dropdown#7193
waleedlatif1 merged 1 commit into
stagingfrom
codex/column-dropdown-cleanup

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • list Enrichments with the standard column options
  • rename the dropdown component and remove stale exports and lint issues
  • add regression coverage for menu order and behavior

Type of Change

  • Improvement

Testing

  • bun run lint
  • bun run check:audits
  • bunx turbo run type-check
  • bun run test

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Aug 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Aug 28, 2026 2:29am

Request Review

@greptile-apps

greptile-apps Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR simplifies and renames the table column dropdown while presenting Enrichments after the standard column options.

  • Renames NewColumnDropdown to ColumnDropdown and updates its barrels and consumers.
  • Moves Enrichments to the end of the unified options list and removes the separator and obsolete height override.
  • Removes unused type exports, applies lint formatting, and adds regression coverage for menu ordering and selection.

Confidence Score: 5/5

The PR appears safe to merge with no actionable correctness, security, or quality issues identified.

The renamed exports are updated consistently across all consumers, and the shared dropdown’s scrollable height accommodates the complete nine-item menu.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/column-dropdown/column-dropdown.tsx Renames the component and integrates Enrichments into the standard dropdown list without introducing a concrete behavioral defect.
apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/column-dropdown/column-dropdown.test.tsx Adds focused coverage for option order, separator removal, and Enrichments selection.
apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/table-grid.tsx Updates the inline table-header consumer to the renamed dropdown and applies behavior-neutral formatting.
apps/sim/app/workspace/[workspaceId]/tables/[tableId]/table.tsx Updates the page-header consumer to use the renamed barrel export.
apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/column-config-sidebar/column-types.ts Stops exporting internal option types that have no remaining external consumers.

Reviews (1): Last reviewed commit: "improvement(tables): simplify column dro..." | Re-trigger Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 9 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 603f1c2 into staging Aug 28, 2026
30 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/column-dropdown-cleanup branch August 28, 2026 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant