Skip to content

fix(workflows): authorize automated runs by deployment - #7181

Merged
TheodoreSpeaks merged 2 commits into
stagingfrom
fix/webhook-actorless-internal-apis
Aug 28, 2026
Merged

fix(workflows): authorize automated runs by deployment#7181
TheodoreSpeaks merged 2 commits into
stagingfrom
fix/webhook-actorless-internal-apis

Conversation

@TheodoreSpeaks

@TheodoreSpeaks TheodoreSpeaks commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • authorize actorless and external webhook executions through their bound deployed workflow
  • keep billing-owner IDs limited to legacy storage and provenance attribution
  • preserve generic webhook, schedule, and Slack principal semantics without inventing Sim users

Type of Change

  • Bug fix

Testing

  • 323 focused tests
  • app and auth type checks
  • lint, block-registry validation, and 37 repository audits

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added or updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Aug 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Aug 28, 2026 12:38am

Request Review

@greptile-apps

greptile-apps Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR authorizes subjectless automated executions through their bound deployed workflow while preserving generic webhook, schedule, and external-provider principal semantics.

  • Adds deployment-backed authorization for actorless executor delegations.
  • Separates human subjects from billing and legacy storage attribution.
  • Updates knowledge and table provenance handling and adds focused compatibility tests.

Confidence Score: 5/5

The PR appears safe to merge because no blocking failure remains.

No blocking failure remains.

Important Files Changed

Filename Overview
packages/auth/src/principal.ts Keeps actorless webhook principals subjectless while extending delegated executor attribution.
apps/sim/lib/core/application/workspace-authorization.ts Authorizes actorless executor operations only when the current workflow authority represents a deployment.
apps/sim/lib/knowledge/api/internal-route.ts Separates Knowledge authorization subjects, analytics identities, billing restoration, and persisted provenance.
apps/sim/lib/table/application/rows.ts Allows actorless deployed executions to use workspace-scoped table provenance handling.
apps/sim/lib/billing/core/billing-attribution.ts Adds restoration of trusted executor billing snapshots constrained by canonical workspace.

Reviews (2): Last reviewed commit: "fix(workflows): authorize automated runs..." | Re-trigger Greptile

Comment thread packages/auth/src/principal.ts

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 14 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@TheodoreSpeaks
TheodoreSpeaks force-pushed the fix/webhook-actorless-internal-apis branch from b9dfb5d to 7a5b8f4 Compare August 28, 2026 00:28
@TheodoreSpeaks TheodoreSpeaks changed the title fix(workflows): bind automated runs to billing actors fix(workflows): authorize automated runs by deployment Aug 28, 2026
@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@greptile

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@cubic review

@cubic-dev-ai

cubic-dev-ai Bot commented Aug 28, 2026

Copy link
Copy Markdown

@cubic review

@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 20 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@TheodoreSpeaks
TheodoreSpeaks merged commit 56c7003 into staging Aug 28, 2026
28 checks passed
@TheodoreSpeaks
TheodoreSpeaks deleted the fix/webhook-actorless-internal-apis branch August 28, 2026 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant