fix(landing): reset unmeasurable preview stages - #7153
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryThe PR fixes responsive landing previews that retain stale visibility and scaling state while their host has no measurable space.
Confidence Score: 5/5The PR appears safe to merge, with the corrected zero-scale handling restoring previews when measurable space returns. The changed branch resets the cached scale while hiding an unmeasurable surface, and the subsequent nonzero ResizeObserver delivery reapplies both scale and opacity; regression coverage exercises the complete transition.
|
| Filename | Overview |
|---|---|
| apps/sim/app/(landing)/components/shared/responsive-design-stage/responsive-design-stage.tsx | Correctly hides unmeasurable preview surfaces and resets cached scale state so visibility and scaling recover on the next measurable resize. |
| apps/sim/app/(landing)/components/shared/responsive-design-stage/responsive-design-stage.test.ts | Adds a jsdom ResizeObserver regression test covering measurable, collapsed, and restored host dimensions. |
Reviews (1): Last reviewed commit: "fix(landing): reset unmeasurable preview..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Checklist