Skip to content

fix(landing): reset unmeasurable preview stages - #7153

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/fix-responsive-stage-zero-scale
Aug 27, 2026
Merged

fix(landing): reset unmeasurable preview stages#7153
waleedlatif1 merged 1 commit into
stagingfrom
codex/fix-responsive-stage-zero-scale

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • hide responsive landing stages when their host has no measurable space
  • reset the applied-scale sentinel so the same scale is restored when space returns
  • add regression coverage for visible, hidden, and restored resize states

Type of Change

  • Bug fix

Testing

  • Full lint and 36 repository audits
  • Full type-check
  • Responsive design stage tests (5 passing)

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Aug 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Aug 27, 2026 4:45am

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR fixes responsive landing previews that retain stale visibility and scaling state while their host has no measurable space.

  • Hides the design surface whenever its calculated scale is zero.
  • Resets the applied-scale sentinel so the same scale is reapplied when measurable space returns.
  • Adds regression coverage for visible, hidden, and restored resize states.

Confidence Score: 5/5

The PR appears safe to merge, with the corrected zero-scale handling restoring previews when measurable space returns.

The changed branch resets the cached scale while hiding an unmeasurable surface, and the subsequent nonzero ResizeObserver delivery reapplies both scale and opacity; regression coverage exercises the complete transition.

Important Files Changed

Filename Overview
apps/sim/app/(landing)/components/shared/responsive-design-stage/responsive-design-stage.tsx Correctly hides unmeasurable preview surfaces and resets cached scale state so visibility and scaling recover on the next measurable resize.
apps/sim/app/(landing)/components/shared/responsive-design-stage/responsive-design-stage.test.ts Adds a jsdom ResizeObserver regression test covering measurable, collapsed, and restored host dimensions.

Reviews (1): Last reviewed commit: "fix(landing): reset unmeasurable preview..." | Re-trigger Greptile

@waleedlatif1
waleedlatif1 merged commit 752c21c into staging Aug 27, 2026
30 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/fix-responsive-stage-zero-scale branch August 27, 2026 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant