Skip to content

fix(cli): exit after interactive secret input - #7118

Merged
TheodoreSpeaks merged 1 commit into
stagingfrom
fix/cli-secret-hang
Aug 26, 2026
Merged

fix(cli): exit after interactive secret input#7118
TheodoreSpeaks merged 1 commit into
stagingfrom
fix/cli-secret-hang

Conversation

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator

Summary

  • Stop interactive secret entry from keeping stdin active after completion
  • Add Node stream-state regression coverage and bump the CLI to 2.1.2

Type of Change

  • Bug fix

Testing

  • Manually verified the interactive process exits successfully
  • Passed CLI tests, type check, production build, root lint, block registry, docs manifest, and all repo audits

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@TheodoreSpeaks
TheodoreSpeaks requested a review from a team as a code owner August 26, 2026 19:32
@vercel

vercel Bot commented Aug 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview Aug 26, 2026 7:38pm

Request Review

@greptile-apps

greptile-apps Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR updates interactive secret entry to pause stdin after completion or cancellation so the CLI process can exit normally.

  • Unconditionally pauses the input stream during secret-prompt cleanup.
  • Adds regression coverage using Node-compatible readableFlowing semantics.
  • Bumps the sim CLI package from 2.1.1 to 2.1.2 in the manifest and lockfile.

Confidence Score: 5/5

The PR appears safe to merge, with the stdin lifecycle fix covered by focused regression tests and no reachable caller regression identified.

The only production caller finishes its secret interaction before performing non-interactive request and rendering work, while release metadata remains consistently derived from the package manifest.

Important Files Changed

Filename Overview
packages/sim-cli/src/terminal/secret-input.ts Cleanup now always pauses stdin after restoring raw mode, addressing the process-liveness issue without disrupting any current caller.
packages/sim-cli/src/terminal/secret-input.test.ts The fake stream now models Node's idle and flowing states and verifies pausing after successful and cancelled prompts.
packages/sim-cli/package.json Bumps the published CLI version to 2.1.2 consistently with the lockfile.
bun.lock Updates the sim-cli workspace package metadata to version 2.1.2.

Reviews (1): Last reviewed commit: "fix(cli): exit after interactive secret ..." | Re-trigger Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@TheodoreSpeaks
TheodoreSpeaks merged commit 437ffa3 into staging Aug 26, 2026
30 checks passed
@TheodoreSpeaks
TheodoreSpeaks deleted the fix/cli-secret-hang branch August 26, 2026 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant