fix(cli): exit after interactive secret input - #7118
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Greptile SummaryThis PR updates interactive secret entry to pause stdin after completion or cancellation so the CLI process can exit normally.
Confidence Score: 5/5The PR appears safe to merge, with the stdin lifecycle fix covered by focused regression tests and no reachable caller regression identified. The only production caller finishes its secret interaction before performing non-interactive request and rendering work, while release metadata remains consistently derived from the package manifest.
|
| Filename | Overview |
|---|---|
| packages/sim-cli/src/terminal/secret-input.ts | Cleanup now always pauses stdin after restoring raw mode, addressing the process-liveness issue without disrupting any current caller. |
| packages/sim-cli/src/terminal/secret-input.test.ts | The fake stream now models Node's idle and flowing states and verifies pausing after successful and cancelled prompts. |
| packages/sim-cli/package.json | Bumps the published CLI version to 2.1.2 consistently with the lockfile. |
| bun.lock | Updates the sim-cli workspace package metadata to version 2.1.2. |
Reviews (1): Last reviewed commit: "fix(cli): exit after interactive secret ..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Checklist