feat(workflows): expose authenticated run subjects - #7088
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile SummaryThe PR propagates authenticated subjects through workflow execution and exposes normalized identity metadata to Start blocks while keeping actorless runs identity-free.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; the previously reported untyped authentication fixture now uses a typed
|
| Filename | Overview |
|---|---|
| apps/sim/app/api/chat/utils.test.ts | Replaces ad-hoc authentication request casts with typed NextRequest fixtures using real Cookie headers, resolving the prior review concern. |
| apps/sim/lib/core/security/deployment.ts | Extends signed deployment authentication tokens to preserve normalized authenticated-email subjects. |
| apps/sim/lib/workflows/executor/start-run-identity.ts | Normalizes trusted execution principals into optional Start-block subject metadata. |
| apps/sim/lib/workflows/executor/execution-core.ts | Propagates authenticated principal identity into workflow execution and Start metadata. |
| apps/sim/executor/handlers/workflow/workflow-handler.ts | Preserves principal subjects across nested workflow execution boundaries. |
| apps/sim/lib/credential-groups/credentials.ts | Applies subject-aware constraints when resolving credentials for authenticated workflow runs. |
| packages/auth/src/principal.ts | Defines the shared principal-subject contract used across authentication and execution layers. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
A[Authenticated caller] --> B[Normalized principal subject]
B --> C[Workflow execution context]
C --> D{Execution path}
D --> E[Synchronous run]
D --> F[Queued or resumed run]
D --> G[Nested workflow]
E --> H[Start run metadata]
F --> H
G --> H
H --> I[Subject-scoped credential access]
J[Actorless caller] --> K[Identity-free execution]
Reviews (2): Last reviewed commit: "fix(auth): harden subject delegation and..." | Re-trigger Greptile
There was a problem hiding this comment.
All reported issues were addressed across 90 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
b3ca91c to
266f4fc
Compare
|
@cursor review |
|
Skipping Bugbot: Bugbot is disabled for this repository. Visit the Bugbot dashboard to update your settings. |
Summary
Type of Change
Testing
Checklist