feat(resource-policies): add statement evaluator - #6892
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryHigh Risk Overview Adds a required per-group policy lifecycle (create/delete/backfill), optimistic-concurrency admin GET/PUT, and a settings Access tab. Credential use now evaluates Threads current workflow (draft vs active deployment version) through executor delegation and child-workflow execution so workflow principals and Reviewed by Cursor Bugbot for commit a01a557. Bugbot is set up for automated code reviews on this repo. Configure here. |
9995853 to
0c9fb23
Compare
Greptile SummaryThe PR replaces credential-group grants with statement-based resource policies and carries workflow authority through credential resolution and execution.
Confidence Score: 5/5The PR appears safe to merge because no blocking failure remains within the eligible follow-up scope. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| apps/sim/lib/credential-groups/application/authorization.ts | Connects delegated execution principals and workflow authority to credential-group policy evaluation. |
| apps/sim/lib/credential-groups/application/workflow-access-policy.ts | Defines and evaluates the bounded workflow-access policy representation. |
| apps/sim/lib/resource-policies/repository.ts | Adds workspace-scoped policy reads and revision-controlled writes. |
| apps/sim/lib/workflows/executor/execution-core.ts | Carries deployment authority into initial and resumed workflow execution. |
| apps/sim/lib/workflows/executor/human-in-the-loop-manager.ts | Validates and restores deployment-version context when resuming paused executions. |
| packages/db/credential-group-resource-policies.ts | Implements credential-group policy lifecycle synchronization, bounded backfill, and invariant validation. |
| packages/db/migrations/0308_glorious_hellion.sql | Introduces the resource-policy persistence schema and supporting constraints. |
| apps/sim/ee/credential-groups/components/credential-group-access.tsx | Adds the revision-aware workflow access editor for credential groups. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
A[Workflow execution] --> B[Persisted execution principal]
B --> C[Current workflow authority]
C --> D[Credential resolution]
D --> E[Credential-group resource policy]
E --> F{Statement evaluation}
F -->|Allow| G[Managed credential token]
F -->|No match or deny| H[Access refused]
I[Workspace administrator] --> J[Workflow access editor]
J --> K[Policy repository]
K --> E
L[Credential-group lifecycle] --> M[Trigger and bounded backfill]
M --> K
Reviews (7): Last reviewed commit: "Merge remote-tracking branch 'origin/fea..." | Re-trigger Greptile
aaea6ae to
52e3168
Compare
95eafd9 to
9d5f513
Compare
c2d891e to
64f547f
Compare
64f547f to
eccb03a
Compare
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
3 issues from previous reviews remain unresolved.
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit eccb03a. Configure here.
eccb03a to
ede2aba
Compare
|
@cursor review |
fab4e47 to
a01a557
Compare
|
@cursor review |
|
Skipping Bugbot: Bugbot is disabled for this repository. Visit the Bugbot dashboard to update your settings. |
|
@cursor review |
|
Skipping Bugbot: Bugbot is disabled for this repository. Visit the Bugbot dashboard to update your settings. |
…eat/credential-group-resource-policies

Summary
Type of Change
Testing
Checklist