fix: raise NoTable from rows_where() and delete_where() for non-existent tables - #850
Open
ikatyal2110 wants to merge 1 commit into
Open
fix: raise NoTable from rows_where() and delete_where() for non-existent tables#850ikatyal2110 wants to merge 1 commit into
ikatyal2110 wants to merge 1 commit into
Conversation
…ent tables rows_where() silently returned an empty iterator and delete_where() silently returned self when called on a table that does not exist. This masked bugs in callers that passed a wrong table name. Both methods now raise NoTable (matching the behaviour of count_where() and duplicate()), as planned for the v5 release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rows_where() silently returned an empty iterator and delete_where() silently returned self when called on a table that does not exist, masking bugs in callers that passed a wrong table name. Both methods now raise NoTable, matching the behaviour of count_where() and duplicate(), as described in issue #841 as the intended v5 behaviour. Fixes #841
📚 Documentation preview 📚: https://sqlite-utils--850.org.readthedocs.build/en/850/