Ignore the request checksum when creating a delete marker by maeldonn · Pull Request #6267 · scality/cloudserver

maeldonn · 2026-09-01T15:15:11Z

A delete marker has no body, but createAndStoreObject took its checksum
from the request headers, which on a multi-object delete cover the request
XML. On an external location the mismatch failed the put, and the rollback
error then hit an unguarded result.versionId in multiObjectDelete, killing
the worker with a 502. Skip the header checksum for delete markers, and
guard the result so any later error is returned as a proper S3 error.

Issue: CLDSRV-984

bert-e · 2026-09-01T15:15:14Z

Hello maeldonn,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/bypass_source_branch_lineage`	Bypass the cross-branch contamination check	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request.
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e · 2026-09-01T15:15:20Z

Incorrect fix version

The Fix Version/s in issue CLDSRV-985 contains:

None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

9.4.3
9.5.0

Please check the Fix Version/s of CLDSRV-985, or the target
branch of this pull request.

codecov · 2026-09-01T15:16:03Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.51%. Comparing base (7ebd00d) to head (8973707).
⚠️ Report is 2 commits behind head on development/9.4.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Files with missing lines	Coverage Δ
lib/api/apiUtils/object/createAndStoreObject.js	`87.19% <100.00%> (+0.77%)`	⬆️
lib/api/multiObjectDelete.js	`83.69% <100.00%> (ø)`

... and 1 file with indirect coverage changes

@@                 Coverage Diff                 @@
##           development/9.4    #6267      +/-   ##
===================================================
+ Coverage            86.50%   86.51%   +0.01%     
===================================================
  Files                  212      212              
  Lines                14579    14581       +2     
===================================================
+ Hits                 12611    12615       +4     
+ Misses                1968     1966       -2

Flag	Coverage Δ
checksums-disabled-tests	`35.31% <71.42%> (+<0.01%)`	⬆️
file-ft-tests	`70.05% <100.00%> (-0.01%)`	⬇️
file-ft-tests-null-compat	`70.48% <100.00%> (+<0.01%)`	⬆️
kmip-ft-tests	`28.07% <71.42%> (-0.19%)`	⬇️
mongo-v0-ft-tests	`71.11% <100.00%> (-0.05%)`	⬇️
mongo-v1-ft-tests	`71.12% <100.00%> (+0.02%)`	⬆️
multiple-backend	`36.08% <71.42%> (+<0.01%)`	⬆️
s3c-ft-tests-v0	`65.02% <85.71%> (+<0.01%)`	⬆️
s3c-ft-tests-v0-null-compat	`65.07% <85.71%> (+<0.01%)`	⬆️
s3c-ft-tests-v1	`65.00% <85.71%> (-0.01%)`	⬇️
sur-tests	`37.49% <71.42%> (+0.87%)`	⬆️
sur-tests-inflights	`39.42% <71.42%> (-0.02%)`	⬇️
unit	`74.19% <85.71%> (+0.01%)`	⬆️
utapi-v2-tests	`35.29% <85.71%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

bert-e · 2026-09-01T15:22:59Z

Incorrect fix version

The Fix Version/s in issue CLDSRV-985 contains:

9.5.0

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

9.4.3
9.5.0

Please check the Fix Version/s of CLDSRV-985, or the target
branch of this pull request.

bert-e · 2026-09-02T12:42:57Z

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

DarkIsDude

A "nits" for you

A delete marker has no body, but createAndStoreObject took its checksum from the request headers, which on a multi-object delete cover the request XML. On an external location the mismatch failed the put, and the rollback error then hit an unguarded result.versionId in multiObjectDelete, killing the worker with a 502. Skip the header checksum for delete markers, and guard the result so any later error is returned as a proper S3 error. Issue: CLDSRV-984

Issue: CLDSRV-985

maeldonn · 2026-09-10T12:59:14Z

/approve

bert-e · 2026-09-10T12:59:26Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge bugfix/CLDSRV-985 into
development/9.4
w/9.5/bugfix/CLDSRV-985 will be merged into development/9.5

The following branches will NOT be impacted:

development/7.10
development/7.4
development/7.70
development/8.8
development/9.0
development/9.1
development/9.2
development/9.3

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

bert-e · 2026-09-10T13:50:50Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/9.4
✔️ development/9.5

The following branches have NOT changed:

development/7.10
development/7.4
development/7.70
development/8.8
development/9.0
development/9.1
development/9.2
development/9.3

This pull request did not target the following hotfix branch(es) so they
were left untouched:

hotfix/7.70.11
hotfix/7.10.15
hotfix/7.70.45
hotfix/7.9.0
hotfix/9.0.7
hotfix/7.10.1
hotfix/7.10.3
hotfix/7.70.21
hotfix/9.2.36
hotfix/7.10.2
hotfix/7.10.4
hotfix/7.6.0
hotfix/7.70.51
hotfix/7.4.1
hotfix/7.10.27
hotfix/7.8.0
hotfix/7.10.30
hotfix/7.4.3
hotfix/6.4.7
hotfix/7.4.5
hotfix/7.4.6
hotfix/7.4.4
hotfix/7.4.2
hotfix/7.4.8
hotfix/7.10.8
hotfix/8.8.45
hotfix/7.4.7
hotfix/9.3.13
hotfix/9.2.24
hotfix/7.70.73
hotfix/7.10.0
hotfix/7.10.28
hotfix/7.4.10
hotfix/9.0.32
hotfix/7.4.0
hotfix/7.2.0
hotfix/7.10.49
hotfix/7.4.9
hotfix/7.7.0

Please check the status of the associated issue CLDSRV-985.

Goodbye maeldonn.

The following options are set: approve

maeldonn requested review from a team, DarkIsDude and SylvainSenechal September 1, 2026 15:15

maeldonn requested a review from leif-scality September 1, 2026 15:15

leif-scality reviewed Sep 1, 2026

View reviewed changes

Comment thread lib/api/apiUtils/object/createAndStoreObject.js Outdated

Comment thread lib/api/apiUtils/object/createAndStoreObject.js

maeldonn force-pushed the bugfix/CLDSRV-985 branch from 0d7205f to 06ea87b Compare September 2, 2026 12:44

maeldonn requested a review from leif-scality September 2, 2026 12:45

maeldonn marked this pull request as ready for review September 2, 2026 12:45

leif-scality approved these changes Sep 2, 2026

View reviewed changes

DarkIsDude approved these changes Sep 3, 2026

View reviewed changes

Comment thread lib/api/apiUtils/object/createAndStoreObject.js

maeldonn force-pushed the bugfix/CLDSRV-985 branch from 06ea87b to e5e9f93 Compare September 10, 2026 12:06

scality deleted a comment from bert-e Sep 10, 2026

maeldonn added 2 commits September 10, 2026 14:31

Reformat with prettier

8973707

Issue: CLDSRV-985

maeldonn force-pushed the bugfix/CLDSRV-985 branch from e5e9f93 to 8973707 Compare September 10, 2026 12:32

bert-e merged commit 8973707 into development/9.4 Sep 10, 2026
38 checks passed

bert-e deleted the bugfix/CLDSRV-985 branch September 10, 2026 13:50

Navigation Menu

Uh oh!

Ignore the request checksum when creating a delete marker - #6267

Ignore the request checksum when creating a delete marker #6267
bert-e merged 2 commits into
development/9.4from
bugfix/CLDSRV-985

maeldonn commented Sep 1, 2026 •

edited by atlassian Bot

Loading

Uh oh!

bert-e commented Sep 1, 2026

Uh oh!

bert-e commented Sep 1, 2026

Uh oh!

codecov Bot commented Sep 1, 2026 •

edited

Loading

Uh oh!

bert-e commented Sep 1, 2026

Uh oh!

Uh oh!

Uh oh!

bert-e commented Sep 2, 2026

Uh oh!

DarkIsDude left a comment

Uh oh!

Uh oh!

maeldonn commented Sep 10, 2026

Uh oh!

bert-e commented Sep 10, 2026

Uh oh!

bert-e commented Sep 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

maeldonn commented Sep 1, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bert-e commented Sep 1, 2026

Hello maeldonn,

Uh oh!

bert-e commented Sep 1, 2026

Incorrect fix version

Uh oh!

codecov Bot commented Sep 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

bert-e commented Sep 1, 2026

Incorrect fix version

Uh oh!

Uh oh!

Uh oh!

bert-e commented Sep 2, 2026

Request integration branches

Uh oh!

DarkIsDude left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

maeldonn commented Sep 10, 2026

Uh oh!

bert-e commented Sep 10, 2026

Integration data created

Uh oh!

bert-e commented Sep 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

maeldonn commented Sep 1, 2026 •

edited by atlassian Bot

Loading

codecov Bot commented Sep 1, 2026 •

edited

Loading