fix: promote all matched VSIXs, not just the first - W-23900552 - #183
Merged
Conversation
The publish job downloaded every VSIX from the nightly release but then selected a single file via 'find ... | head -1' and published only that one. This works for single-extension repos (their vsix-name-pattern matches exactly one file) but silently promotes only one extension for the salesforcedx-vscode monorepo (17 VSIXs), leaving the other 16 unpublished. Loop over every VSIX matching vsix-name-pattern (honoring exclude-web) and publish each as pre-release with --skip-duplicate, per registry. fail-fast: false so one extension's failure doesn't abort the rest; the job still fails (and tag-promoted is skipped) if any publish fails. Uses a portable while-read array build and keeps a per-file audit line. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mshanemc
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
vscode-promote-prerelease.ymldownloaded every VSIX from the nightly GitHub release but then published only one — it selected a single file withfind ... | head -1and passed that lone path to thepublish-vsixaction.Why it matters
This is fine for single-extension repos (their
vsix-name-patternmatches exactly one file), but for the salesforcedx-vscode monorepo the release carries 17 VSIXs. A real promote run (forcedotcom/salesforcedx-vscode run 33817469982) published onlysalesforcedx-vscode-lightningand silently left the other 16 unpublished — while still creating themarketplace-prerelease-*tracking tag, which makes a naive rerun look "already promoted."Change
vsix-name-pattern(honoringexclude-web-vsix) and publishes each as pre-release with--skip-duplicate, per registry (vsce, ovsx).fail-fast: falseso one extension's failure doesn't abort the rest; the job still fails (andtag-promotedis skipped) if any publish fails.while readarray build (nomapfiledependency); keeps a per-file[AUDIT]line mirroring the oldpublish-vsixaudit.Testing
runblock passesbash -n.salesforcedx-vscode-*.vsix, exclude-web=false → all files published-web-VSIX dropped@W-23900552@