Fixes #1458 | Implement null check for LocalPlayer in renderLevel - #1554
Open
Rodriggrr wants to merge 1 commit into
Open
Fixes #1458 | Implement null check for LocalPlayer in renderLevel#1554Rodriggrr wants to merge 1 commit into
Rodriggrr wants to merge 1 commit into
Conversation
Add null check for player in renderLevel method. Fixes ryanhcode#1458
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
GameRendererMixin.renderLeveldereferencesthis.minecraft.playerwithout anull check. During the window between connecting to a server and the player
entity being fully assigned,
renderLevelstill runs and throws an NPE,crashing the client. This is 100% reproducible on multiplayer connect but
doesn't show up in singleplayer, matching the reports in #1458 and #107.
Fix
Add a null check at the top of the injected method; reset
sable$lastSubLeveland return early if
playeris null, matching the existing behavior in theelsebranch.Fixes #1458