Skip to content

test: abort with a clear message when built assets are missing #7204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
compwron merged 1 commit into from
Sep 21, 2026
+10 −1
Merged

test: abort with a clear message when built assets are missing #7204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ new tab in the browser.
To see local email previews, check out http://localhost:3000/rails/mailers

### Running Tests
- run the ruby test suite `bin/rails spec`
- run the ruby test suite `bin/rails spec`. It builds the JS and CSS bundles first; a bare `bundle exec rspec` does not, so run `npm run build` and `npm run build:css` (or `bin/setup`) once before using it
- run the javascript test suite `npm run test`

If you have trouble running tests, check out CI scripts in [`.github/workflows/`](.github/workflows/) for sample commands.
Expand Down
9 changes: 9 additions & 0 deletions spec/rails_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,15 @@
abort e.to_s.strip
end

# app/assets/builds/ is gitignored and only populated by `npm run build` and
# `npm run build:css`. Until then any layout that links those bundles fails,
# and for tailwind.css with a misleading AssetNotPrecompiledError that points
# at manifest.js. Fail early with the real fix instead.
missing_assets = %w[application.js all_casa_admin.js tailwind.css].reject { |asset| Rails.root.join("app/assets/builds", asset).exist? }
if missing_assets.any?
abort "Missing built assets: #{missing_assets.join(", ")}. Run `npm run build` and `npm run build:css`, or use `bin/rails spec`, which builds them."
end

ci_environment = (ENV["GITHUB_ACTIONS"] || ENV["CI"]).present?

RSpec.configure do |config|
Expand Down
Loading