Accept open-ended typed ranges in runtime checks - #3138
Open
OskarEichler wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Runtime checking for
Range[T]validates both endpoints asT. Beginless and endless ranges usenilfor one endpoint, so validRange[Integer]values such as..10and1..are rejected.Treat a missing endpoint as the range boundary marker and validate only endpoints that are present. The nil check uses the runtime checker's
Test.callprimitive so it also supports minimalBasicObjectendpoint doubles exercised by RBS.Verification
nil?directlySource-only change; no test file is included.