Skip to content

Preserve runtime prototype keyword rest names - #3128

Open
OskarEichler wants to merge 2 commits into
ruby:masterfrom
OskarEichler:codex/runtime-keyrest-name
Open

Preserve runtime prototype keyword rest names#3128
OskarEichler wants to merge 2 commits into
ruby:masterfrom
OskarEichler:codex/runtime-keyrest-name

Conversation

@OskarEichler

Copy link
Copy Markdown

Summary: retain named keyword-rest parameters in runtime prototypes while continuing to normalize the anonymous forwarding sentinel.

Verification: focused baseline/fixed reproduction, combined RBS 4.2.0 consumer models, and RuboCop (738 files, zero offenses). No tests are added in this PR.

Compatibility: no public API removal or dependency/version change.

@OskarEichler

Copy link
Copy Markdown
Author

The implementation correctly changes runtime prototype output for named keyword-rest parameters, but the existing focused expectations still asserted the old anonymous form. I updated both merge and non-merge expectations in f7fa06f. The focused runtime prototype suite now passes (18 tests, 27 assertions, 1 expected omission), targeted RuboCop is clean, and git diff --check passes. The remaining ruby-head stdlib errors are shared upstream drift and unrelated to this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant