Skip to content

Honor exception: false for strings with null bytes #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tompng merged 2 commits into from
Sep 12, 2026
+7 −0
Merged

Honor exception: false for strings with null bytes #550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
efc4593
Honor exception false for strings with null bytes
OskarEichler Aug 29, 2026
092c639
Add test for BigDecimal("1\0", exception: false)
tompng Sep 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ext/bigdecimal/bigdecimal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2845,6 +2845,7 @@ rb_cstr_convert_to_BigDecimal(const char *c_str, int raise_exception)
static inline VALUE
rb_str_convert_to_BigDecimal(VALUE val, int raise_exception)
{
if (!raise_exception && memchr(RSTRING_PTR(val), '\0', RSTRING_LEN(val))) return Qnil;
const char *c_str = StringValueCStr(val);
return rb_cstr_convert_to_BigDecimal(c_str, raise_exception);
}
Expand Down
6 changes: 6 additions & 0 deletions test/bigdecimal/test_bigdecimal.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,12 @@ def test_BigDecimal_with_exception_keyword
assert_nothing_raised(ArgumentError) {
assert_equal(nil, BigDecimal(".", exception: false))
}
assert_raise(ArgumentError) {
BigDecimal("1\0", exception: true)
}
assert_nothing_raised(ArgumentError) {
assert_equal(nil, BigDecimal("1\0", exception: false))
}
assert_raise(ArgumentError) {
BigDecimal("1", -1, exception: true)
}
Expand Down