Strip complete version constraints without joining package names - #51
Open
OskarEichler wants to merge 2 commits into
Open
OskarEichler wants to merge 2 commits into
OskarEichler wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consume the complete version token and != operator while preserving the separator between dependency names.
Reproduction and verification
Requires: foo >= 1.2.3+build, barcurrently invents a+builddependency.foo != 1.0, barinvents!; compactfoo>=1.0 barbecomesfoobar. The candidate extracts["foo", "bar"]. Versions containing~or:have the same token-boundary problem.Ninety combinations of operators, version tokens and spacing pass on the candidate. Existing six version-parser tests pass. Native pkgconf 3.0.6 inspection also accepts version tokens with +, ~ and :; the compact syntax corpus additionally preserves the Ruby parser’s existing permissiveness and is not claimed to match every native grammar rule.
Existing suite on Ruby 4.0.6 through rbenv: 27 tests, 31 assertions, zero failures/errors, two upstream macOS omissions, baseline and this isolated patch. Combined installed-release consumer also passes the suite, 1,098 focused/model checks, four process cases, five linker-option cases and four path cases.
rbenv exec ruby test/run.rbruns the existing suite.Compatibility and limitations
No version solver is introduced: requirements continue to return names, not enforce constraints. Previously misparsed valid requirements now resolve the intended names. Invalid/quoted dependency syntax remains outside this change.
No tests were added or modified under the consuming repository's no-new-tests policy. Verification uses existing tests and external scratch reproductions. No production changes; older Ruby/Linux/Windows matrices await upstream CI. No unrelated version/dependency changes.