Conversation
|
Looks reasonable assuming tested successfully. |
rswgnu
left a comment
rswgnu
left a comment
There was a problem hiding this comment.
Rebase off master and the trailing whitespace changes should disappear so we can consider further changes without those. Also, see inline comments.
| There are multiple package managers you can use to install Hyperbole once | ||
| you have GNU Emacs set up at your site. Choose one based on your needs. | ||
| Hyperbole can be installed using Emacs' package manager, from its | ||
| development repository or manually from the tarball archive. |
There was a problem hiding this comment.
The above change looks like a regression to me.
There was a problem hiding this comment.
Yes I understand that. I want to put less emphasis on choosing a packet manager. and more focus on that the user already has an Emacs capable of installing Hyperbole. So lowering the bar so to speak. Users who already use other package managers will not be confused by this. Or what do you think?
| @noindent | ||
| MELPA Snapshots: | ||
|
|
||
| Now save the file and restart Emacs. Hyperbole will then be downloaded |
There was a problem hiding this comment.
Snapshots is equiv to elpa-devel so it should come first and melpa releases should be in the stable release section.
There was a problem hiding this comment.
Yes, that is a bit confusing. I want ELPA to be the users first choice. What do you think of moving info about MELPA to a paragraph telling that it is possible to use MELPA as well if user prefers that. And by that skip the bullet-list removing the mix of stable(release) and devel(snapshot) since that can be confusing?
| For installing from GNU-devel ELPA, MELPA releases or MELPA snapshots | ||
| add the respective archive to package-archives in your init | ||
| file, see @pxref{Init File,,The Emacs Initialization File,emacs, the GNU Emacs | ||
| Manual}. |
* install-test/install-test.sh: Avoid debug check setting the exit status.
* man/use-package (hyperbole): Simplify by removing conditional activation of hyperbole-mode and hywiki-mode. Bind keys in hyperbole-mode-map. Advice how the default hyperbole-menu global activation keys can be changed.
* man/hy-package.el:
* man/hy-straight.el: Deleted, prefer use-package declaration.
* man/hyperbole.texi (Elpa Latest or Release Package Installation):
(Git Latest Package Installation): Use verbatiminclude to avoid
Texinfo interpreting { } chars in use-package.
The configuration section is inserted after the install instructions. Both constitute an Install and Configuration node. The install instructions have thus been changed to work with that organization and have been simplified. The simplification is both removing text and to refer to the package managers documentation rather than to provide running examples. A lot of whitespace at the end of lines have been removed due to me forgetting to turn off delete-trailing-whitespace-mode.
320dc51 to
1070203
Compare
|
@rswgnu I have rebased so you don't have to configure github to ignore whitespace, changed the use-package to avoid hanging parens and added some comments to the PR for the discussion. |
This branch has not been deployed
2 participants
What
Update the use-package declaration and use it in the documentation.
Why
Refactoring the use-package declaration based on feedback from users.
Note
This is a draft PR since the documentation is not updated. That will
be rearranged so that installation and configuration are more
separated.
Installation section will be made shorter to not go into details on
the different package managers. It should suffice to mention what
archives to set the package-archives to or what url the repository is
at more or less.
For the configuration the use-package declaration will be used.