[df] Rework RNTuple MT scheduling with a split work-stealing approach - #23327
Draft
vepadulano wants to merge 1 commit into
Draft
vepadulano wants to merge 1 commit into
vepadulano wants to merge 1 commit into
Conversation
Test Results 23 files 23 suites 3d 20h 37m 44s ⏱️ For more details on these failures, see this check. Results for commit ece30c1. ♻️ This comment has been updated with latest results. |
hageboeck
reviewed
Sep 11, 2026
hageboeck
left a comment
hageboeck
left a comment
Member
There was a problem hiding this comment.
🚀
Here's a first pass with a few suggestions and a few questions.
Comment on lines
946
to
+958
| if (sampleMap.empty()) | ||
| return ROOT::RDF::RSampleInfo( | ||
| ntupleID, std::make_pair(fCurrentRanges[rangeIdx].fFirstEntry, fCurrentRanges[rangeIdx].fLastEntry), nullptr, | ||
| fPrincipalDescriptor.GetNEntries()); | ||
| return ROOT::RDF::RSampleInfo(ntupleID, | ||
| std::make_pair(entryRangeDS.fFirstEntry - entryRangeDS.fEntryOffset, | ||
| entryRangeDS.fLastEntry - entryRangeDS.fEntryOffset), | ||
| nullptr, fPrincipalDescriptor.GetNEntries()); | ||
|
|
||
| if (sampleMap.find(ntupleID) == sampleMap.end()) | ||
| throw std::runtime_error("Full sample identifier '" + ntupleID + "' cannot be found in the available samples."); | ||
|
|
||
| return ROOT::RDF::RSampleInfo( | ||
| ntupleID, std::make_pair(fCurrentRanges[rangeIdx].fFirstEntry, fCurrentRanges[rangeIdx].fLastEntry), | ||
| sampleMap.at(ntupleID), fPrincipalDescriptor.GetNEntries()); | ||
| return ROOT::RDF::RSampleInfo(ntupleID, | ||
| std::make_pair(entryRangeDS.fFirstEntry - entryRangeDS.fEntryOffset, | ||
| entryRangeDS.fLastEntry - entryRangeDS.fEntryOffset), | ||
| sampleMap.at(ntupleID), fPrincipalDescriptor.GetNEntries()); |
Member
There was a problem hiding this comment.
Initially not part of this PR, but looking at these lines, could we unify them for better readability? I was wondering if all arguments of the constructor for both cases are identical (they pretty much are), but it wasn't so easy to see.
How about this?
RSample* sample = nullptr;
if (!sampleMap.empty()) {
if (auto result = sampleMap.find(ntupleID); result != sampleMap.end())
sample = *result;
else
throw std::runtime_error("Full sample identifier '" + ntupleID + "' cannot be found in the available samples.");
}
return ROOT::RDF::RSampleInfo(ntupleID,
std::make_pair(entryRangeDS.fFirstEntry - entryRangeDS.fEntryOffset,
entryRangeDS.fLastEntry - entryRangeDS.fEntryOffset),
sample, fPrincipalDescriptor.GetNEntries());
Member
Author
There was a problem hiding this comment.
I actually find the current look much more readable than your proposal.
| } | ||
| } | ||
|
|
||
| auto processFileWithGlobalOffset = [&](std::size_t fileIdx) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #22631 , implementing native IMT work-stealing for the RNTuple data source