Skip to content

[misc] do not rely on obsolete Riostream.h header and deprecate - #23286

Merged
linev merged 5 commits into
root-project:masterfrom
ferdymercury:riostrmisc
Sep 14, 2026
Merged

[misc] do not rely on obsolete Riostream.h header and deprecate#23286
linev merged 5 commits into
root-project:masterfrom
ferdymercury:riostrmisc

Conversation

@ferdymercury

@ferdymercury ferdymercury commented Sep 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

This Riostream.h header was there 25 years ago when iostream was not yet in the standards.

Use now standard headers, cleaner and more understandable, plus more fine-grained, why should one include three headers when it can just include the needed one.

@ferdymercury ferdymercury added the skip code analysis Skip the code analysis CI steps for this PR, including verifying clang-formatting and running Ruff. label Sep 7, 2026
@jblomer jblomer self-assigned this Sep 7, 2026
ferdymercury
ferdymercury commented Sep 7, 2026
View reviewed changes
Comment thread io/io/src/TStreamerInfo.cxx Outdated
@ferdymercury
ferdymercury marked this pull request as ready for review September 7, 2026 16:24
@guitargeek

guitargeek commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Squash-on-merge would be okay here?

@ferdymercury

ferdymercury commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator Author

Squash-on-merge would be okay here?

For me, always! :)

@github-actions

github-actions Bot commented Sep 8, 2026 •
edited
Loading

Copy link
Copy Markdown

Test Results

    23 files      23 suites   3d 18h 31m 12s ⏱️
 3 878 tests  3 878 ✅ 0 💤 0 ❌
79 177 runs  79 177 ✅ 0 💤 0 ❌

Results for commit 22baf8b.

♻️ This comment has been updated with latest results.

@dpiparo dpiparo closed this Sep 8, 2026
@dpiparo dpiparo reopened this Sep 8, 2026
guitargeek
guitargeek approved these changes Sep 8, 2026
View reviewed changes

@guitargeek guitargeek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jblomer
jblomer approved these changes Sep 8, 2026
View reviewed changes

@jblomer jblomer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jblomer

jblomer commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

@ferdymercury could you rebase to retrigger the CI? I think the failures are all unrelated but given the many touched files I would still prefer to see more green.

@ferdymercury

ferdymercury commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator Author

you rebase to retrigger the CI

sure, done!

@ferdymercury ferdymercury reopened this Sep 9, 2026
@ferdymercury ferdymercury changed the title [misc] do not rely on obsolete Riostream.h header [misc] do not rely on obsolete Riostream.h header and deprecate Sep 10, 2026
@ferdymercury
ferdymercury force-pushed the riostrmisc branch 4 times, most recently from 2c08d4a to 7fdcacf Compare September 11, 2026 14:39
@ferdymercury ferdymercury reopened this Sep 11, 2026
@ferdymercury ferdymercury added the clean build Ask CI to do non-incremental build on PR label Sep 12, 2026
@ferdymercury ferdymercury reopened this Sep 12, 2026
@ferdymercury

ferdymercury commented Sep 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

@guitargeek I see some UTF8 errors in the CI, could it be related to the recent textinput upgrade?
Or maybe it's just a race between both stressgraphics variants writing to same file on disk?

@ferdymercury ferdymercury removed the clean build Ask CI to do non-incremental build on PR label Sep 12, 2026
@guitargeek

guitargeek commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Let's see if these are reproducible failures. I've restarted the CI for now.

@ferdymercury

ferdymercury commented Sep 13, 2026

Copy link
Copy Markdown
Collaborator Author

Let's see if these are reproducible failures.

Yes they seem to fail always in the same platforms.
I wonder if a RUN_SERIAL flag is missing since there are a lot of variants (svg, web, etc)

@ferdymercury ferdymercury mentioned this pull request Sep 13, 2026
Closed
@ferdymercury

ferdymercury commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator Author

Let's see if these are reproducible failures.

Fixed now, CI is fully green now. Sorry for the noise.

@linev
linev merged commit d2f93ef into root-project:master Sep 14, 2026
35 checks passed
@ferdymercury
ferdymercury deleted the riostrmisc branch September 14, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jblomer jblomer jblomer approved these changes
@guitargeek guitargeek guitargeek approved these changes
@lmoneta lmoneta Awaiting requested review from lmoneta lmoneta is a code owner
@dpiparo dpiparo Awaiting requested review from dpiparo dpiparo is a code owner
@hageboeck hageboeck Awaiting requested review from hageboeck hageboeck is a code owner
@pcanal pcanal Awaiting requested review from pcanal pcanal is a code owner
@bellenot bellenot Awaiting requested review from bellenot bellenot is a code owner
@linev linev Awaiting requested review from linev linev is a code owner
@agheata agheata Awaiting requested review from agheata agheata is a code owner
@vepadulano vepadulano Awaiting requested review from vepadulano vepadulano is a code owner

Assignees

@jblomer jblomer

Labels

pr:squash on merge skip code analysis Skip the code analysis CI steps for this PR, including verifying clang-formatting and running Ruff.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ferdymercury @guitargeek @jblomer @linev @dpiparo