Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rollbar-reactive-streams/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ dependencies {
testImplementation("org.apache.commons:commons-lang3:3.12.0")
testImplementation("com.google.code.gson:gson:2.13.2")

testImplementation(platform("io.projectreactor:reactor-bom:2020.0.6"))
testImplementation(platform("io.projectreactor:reactor-bom:2025.0.4"))

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Low: This bumps the one module where Reactor is only a test-time convenience Publisher, and leaves the module that actually integrates with Reactor behind. rollbar-reactive-streams-reactor still pins reactor-bom:2020.0.6 for both compileOnly and testImplementation (rollbar-reactive-streams-reactor/build.gradle:8,18), and the example app that exercises it pins the same old BOM (examples/rollbar-reactive-streams-reactor/build.gradle:15) while being part of the root build (settings.gradle.kts:57). After this merges, ReactorAsyncHttpClient — the code Reactor users actually depend on — is still compiled and tested only against the 2020.0.x line, so the bump buys no real validation of the SDK against modern Reactor, and the repo now carries a 5-year version skew between the two reactive-streams modules. Worth either landing the sibling bumps alongside this one (the compileOnly pin at rollbar-reactive-streams-reactor/build.gradle:8 is the important one, since it determines the Reactor API surface the integration compiles against) or noting explicitly that the base module's test-only pin is intentionally allowed to drift.

testImplementation("io.projectreactor:reactor-core")

// Reuse some of the tests since we're providing compatible implementations
Expand Down
Loading