Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
4495a55 to
78476d8
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a479f8349e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
78476d8 to
701313d
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 701313d0e0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8666 +/- ##
=======================================
Coverage 78.57% 78.58%
=======================================
Files 476 476
Lines 64157 64172 +15
=======================================
+ Hits 50413 50431 +18
+ Misses 13744 13741 -3
🚀 New features to boost your workflow:
|
rescript
@rescript/belt
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
|
Developer playground preview: https://rescript-lang.github.io/rescript/dev-playground/?version=pr-8666 |
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Prepare JSX for future literal text by formatting expression children with explicit braces:
Existing unbraced expressions remain valid syntax. Nested JSX elements stay unwrapped, and existing expression braces do not accumulate.
Child comments move inside the braces. For a single expression child, line wrapping also stays inside the braces, avoiding whitespace between the expression container and its tags:
Standalone comments in empty elements or between nested elements are wrapped in comment-only containers:
The parser retains these comments without adding a child, preserving the distinction between zero, one, and multiple children. Bare
{}still denotes an empty record expression;{{/* comment */}}keeps an empty record as a child. Line comments retain their style, including when their text contains*/.Literal text parsing and whitespace rules between sibling children remain future work. The next migration step is to reject unbraced expressions before enabling literal text, so existing variable references cannot silently become strings.
Validation:
Supersedes #7863.