Skip to content

Skip rescript-schema-ppx and sury-ppx for unrelated sources - #8662

Merged
cknitt merged 3 commits into
masterfrom
fix/skip-schema-ppx-unrelated-sources
Sep 22, 2026
Merged

cknitt merged 3 commits into
masterfrom
fix/skip-schema-ppx-unrelated-sources

Conversation

@cknitt

@cknitt cknitt commented Sep 21, 2026

Copy link
Copy Markdown
Member

Avoid running rescript-schema-ppx and sury-ppx on source files that do not contain an @schema annotation.

This extends rewatch’s existing source-triggered PPX filtering, avoiding unnecessary PPX invocations while preserving unconditional execution for unrelated PPXs.

Tests cover both PPX command names, sources with and without @schema, existing source-triggered PPXs, unconditional PPXs, and empty PPX command arrays.

Signed-off-by: Christoph Knittel <ck@cca.io>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e370540d73

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread CHANGELOG.md Outdated
Signed-off-by: Christoph Knittel <ck@cca.io>
@pkg-pr-new

pkg-pr-new Bot commented Sep 21, 2026

Copy link
Copy Markdown

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript@8662

@rescript/belt

npm i https://pkg.pr.new/@rescript/belt@8662

@rescript/darwin-arm64

npm i https://pkg.pr.new/@rescript/darwin-arm64@8662

@rescript/darwin-x64

npm i https://pkg.pr.new/@rescript/darwin-x64@8662

@rescript/linux-arm64

npm i https://pkg.pr.new/@rescript/linux-arm64@8662

@rescript/linux-x64

npm i https://pkg.pr.new/@rescript/linux-x64@8662

@rescript/runtime

npm i https://pkg.pr.new/@rescript/runtime@8662

@rescript/win32-x64

npm i https://pkg.pr.new/@rescript/win32-x64@8662

commit: a6709fe

@github-actions

Copy link
Copy Markdown

@cknitt
cknitt merged commit 53a5709 into master Sep 22, 2026
77 of 79 checks passed
@cknitt
cknitt deleted the fix/skip-schema-ppx-unrelated-sources branch September 22, 2026 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants