Bound PostgreSQL schema suggestion queries - #32
Draft
joe-thom wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
PostgreSQL schema suggestions can now check only whether a table contains data. Interactive schema prompts keep exact row counts by default, while automated callers can stop after the first row.
Why
The agent schema check runs against production read replicas. Full-table counts can run for more than two minutes and then fail when PostgreSQL recovery removes old row versions.
Since August 31, Datadog retained 310 matching production failures across 57 Repls. One newly reported Repl produced 26 retained failures of about 126 to 131 seconds each.
References CLO2-222
Project: DB Sprint
Support thread: Cloud support request
Validation
pnpm --dir drizzle-kit exec vitest run tests/pgSuggestions.test.tspnpm --filter @drizzle-team/drizzle-kit tscpnpm lintThe JavaScript and declaration build completed. The final local
attwpackage check crashed while reading an undefined filename.Rollout
Publish
@drizzle-team/drizzle-kit@0.32.3after merge. Then update pid2 to request the newexistsmode for agent schema checks.A revert is safe. Exact counts remain the default, and this PR writes no database state.
~ written by Zerg 馃懢 (wp-cc5da088)
Linear project: DB Sprint