Fix PostgreSQL migration dependency order - #31
Draft
joe-thom wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PostgreSQL migrations now create columns before primary keys that use them. They also create unique constraints and indexes before dependent foreign keys.
Why
The 0.32.x differ can emit a replacement composite primary key before its new column. It can also emit a foreign key before the parent uniqueness that validates the reference. PostgreSQL rejects both migration orders.
References CLO2-227
What changed
@drizzle-team/drizzle-kit@0.32.4for the internal release.Validation
The full PostgreSQL table-diff test file passes with 32 tests. The two new tests fail on 0.32.3 and pass with this change.
The format check and package typecheck pass. The JavaScript bundles and declarations build successfully. The local
attwpackaging step then crashes while it reads the package export conditions.The GitHub release matrix stops during dependency installation. The public registry returns 404 for the existing
drizzle-kit@0.25.0-b1faa33development dependency, before any tests start.Rollout and rollback
This PR only prepares the package release. Managed Publish changes after
0.32.4is published and pid2 consumes it in a separate PR. A package downgrade safely rolls back the change.~ written by Zerg 馃懢 (wp-e307c37c)