Conversation
|
Hi @aviggiano. Thank you for this PR. Which Redis Open Source release will contain this new feature? I know it's not in 8.10, because it's just about closed. Is it for 8.12? Your PR target needs to be a release-specific feature branch, not main. Once you answer the above, I will create the appropriate branch and then you can edit your PR. Also, this repo does not allow slashes ( |
|
Thanks, it's still unclear which release this will be targeted I'll sync with @sundb and will update the PR |
c02b80f to
4304fa1
Compare
|
Yes, this is for 8.12. I’ve retargeted the PR to |
|
Thank you, @aviggiano. We actually fixed the branch naming issue just recently, so you should be good. Let me know when this PR is ready for review (it's still a draft). |
Signed-off-by: Antonio Viggiano <agfviggiano@gmail.com>
dwdougherty
left a comment
There was a problem hiding this comment.
Hi @aviggiano. Just one comment. Otherwise, these docs look good. Are they ready to be merged to the 8.12 feature branch?
Also, would you mind pointing me to the redis/redis PR? I want to take a look.
| defined on the String type which is treated like a bit vector. | ||
| Since strings are binary safe blobs and their maximum length is 512 MB, | ||
| they are suitable to set up to 2^32 different bits. | ||
| Starting with Redis Open Source 8.12, Redis can store bitmaps in two |
There was a problem hiding this comment.
| Starting with Redis Open Source 8.12, Redis can store bitmaps in two | |
| Starting with Redis 8.12, Redis can store bitmaps in two |
pending approval from @sundb on redis/redis#15331 |
|
Okay. I thought I saw Yaacov say that there were no API changes, but maybe he only meant for milestone 1. I'll hold off on this until I see that the redis/redis PR is merged. I'll then add the new command page. |
Summary
BITOPbehaviorbitmapreturn value to theTYPEcommand referenceWhy
The native Roaring bitmap feature in redis/redis#15331 is targeted for Redis Open Source 8.12. It adds an opt-in representation with an important compatibility boundary: bitmap commands work transparently, while generic string commands do not operate on native bitmap values. Users need that behavior and the rollout requirements documented before enabling the feature.
User impact
Users can evaluate whether Roaring compression fits their workload, enable it safely, understand when existing strings convert, and upgrade replicas and persistence consumers before rollout.
Validation
git diff --checkNote
Low Risk
Documentation-only changes with no runtime or security impact; rollout guidance is descriptive for operators enabling the feature.
Overview
Documents Redis Open Source 8.12 opt-in native Roaring bitmaps (
bitmap/bitmap-roaring) alongside the existing string-backed model.The bitmaps guide is reframed around two representations, adds a Roaring-compressed bitmaps section (
bitmap-default-roaring, conversion on write,BITOPdestination rules,TYPE/OBJECT ENCODINGvs string commands, persistence/replication and upgrade warning), and tightens Performance notes for logicalBITOPlength and sparse/dense tradeoffs. TheTYPEreference now listsbitmapas a possible return value.Reviewed by Cursor Bugbot for commit 68912be. Bugbot is set up for automated code reviews on this repo. Configure here.