[TypeDeclaration] Point ReturnNullableTypeRectorPhp82Test to its own fixtures and config - #8517
Merged
samsonasik merged 1 commit intoSep 23, 2026
Conversation
samsonasik
approved these changes
Sep 23, 2026
TomasVotruba
enabled auto-merge (squash)
September 23, 2026 14:30
Member
|
@TomasVotruba fastunit seems has random error test, even on main branch |
It read the same Fixture directory with the default config, so FixturePhp82 and configured_rule_php82.php never ran, and both test classes wrote the same temporary input files, which fails randomly when the chunks run in parallel (hash_file on a file the other class just deleted).
auto-merge was automatically disabled
September 23, 2026 14:35
Head branch was pushed to by a user without write access
GErpeldinger
force-pushed
the
return-nullable-php82-own-fixtures
branch
from
September 23, 2026 14:35
c339092 to
b5a1cad
Compare
samsonasik
enabled auto-merge (squash)
September 23, 2026 14:36
Member
|
👌 |
Contributor
Author
|
@samsonasik Normally the problem is fixed with the merge of #8513, i rebased this branch since tomas merged it |
Member
|
@GErpeldinger good, thank you 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #6110,
ReturnNullableTypeRectorPhp82TestreadsFixture/withconfigured_rule.php, the same asReturnNullableTypeRectorTest. Onmain, both classes run the same 3 fixtures, andFixturePhp82/standalone_nullable_false.php.incwithconfigured_rule_php82.phpnever runs:Both classes also write the same temporary files next to these fixtures. When fast-unit runs them in parallel chunks, one deletes the other's file, and the test fails randomly, as on #8512: https://github.com/rectorphp/rector-src/actions/runs/35795193352
The test now reads
FixturePhp82/withconfigured_rule_php82.php.Split from #8512, as asked there.
🤖 Drafted with AI assistance.