[CodeQuality] Skip short-circuit dependent values on RepeatedAndNotEqualToNotInArrayRector and RepeatedOrEqualToInArrayRector

[guillaume-sainthillier]

RepeatedAndNotEqualToNotInArrayRector rewrote a chain of null checks where later operands depend on earlier ones:

if (null !== $locale && null !== $translations && null !== $translations->getTranslation($locale))

into

if (!in_array(null, [$locale, $translations, $translations->getTranslation($locale)], true))

The array literal evaluates every item up front, while && stops at the first failing compare. getTranslation() now runs on a null $translations and, with a null $locale, receives an argument its string param does not accept. A nullsafe ?-> would only cover the first case, so the chain has to stay as is. RepeatedOrEqualToInArrayRector had the same issue with ||.

Both rules build the array in InArrayFromRepeatedCompareFactory, which now only accepts values that are safe to evaluate eagerly: plain variables, plus what ExprAnalyzer::isDynamicExpr() already treats as static (scalars, constants, class constants, constant arrays). Method calls, property and array fetches, and $$name keep the original chain.

The compared expression is not restricted: the chain always evaluates it at least once and in_array() evaluates it exactly once.

Fixtures, for each rule:

• skip_short_circuit_dependent_call.php.inc: the case above stays unchanged
• yoda_null_on_variables.php.inc: null !== $a && null !== $b && null !== $c still becomes !in_array(null, [$a, $b, $c], true)

[samsonasik]

looks good 👍

[TomasVotruba]

Thanks