[TypeDeclaration] Skip string param inference in ScalarParamTypeByMethodCallTypeRector to avoid unsafe scalar coercion - #8514
Merged
Conversation
…hodCallTypeRector to avoid unsafe scalar coercion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ScalarParamTypeByMethodCallTypeRectorinferred a param type by copying the declared param type of the called method (CallerParamMatcher::matchCallParamTypereturns the callee param type node verbatim). For astringcallee param this is unsafe: PHP scalar coercion lets a caller legitimately passint/float/bool.Real case: a method passes
$valueto a vendorset(string $key, string $value). The rule addedstring $value, but the caller actually passes anintand relied on coercion. Underdeclare(strict_types=1)this then breaks callers with aTypeError.There is no local signal to tell the safe case from the unsafe one - both are an untyped variable passed to a
stringparam - so the rule now bails out when the inferred type is a plainstring. Non-string scalars and unions (int,bool,float,int|bool,bool|string|null) still get inferred.isMatchingParamType()against purestringintcallee, swap the code sample tointskip_string_caller_paramfixture covering the coercion case